feat: backport #21351 — move storage_slot from partial commitment to completion hash#21587
Merged
benesjan merged 2 commits intoMar 17, 2026
Conversation
Remove noir-projects/protocol-fuzzer/contracts/side_effect_contract/src/main.nr which was modified in the original PR but is not tracked in v4-next (the protocol fuzzer contract was removed from v4-next).
AztecBot
force-pushed
the
claudebox/backport-21351-storage-slot-v4-next
branch
from
fc4b454 to
0f17d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21351 to
v4-next.Moves
storage_slotfrom the partial note commitment (first hash round) to the completion hash (second round). With theOwnedstate variable, the storage slot no longer encodes the owner and can be safely revealed publicly.hash(owner, randomness)instead ofhash(owner, storage_slot, randomness)hash(commitment, storage_slot, value)instead ofhash(commitment, value)storage_slotremoved from private message encoding; extracted from public completion log during note discoveryCherry-pick conflicts
The only conflict was a modify/delete on
noir-projects/protocol-fuzzer/contracts/side_effect_contract/src/main.nr— this file is not tracked inv4-next(protocol fuzzer contract was removed), so the resolution was to delete it.Verification
All affected Noir packages compile successfully:
uint_note,nft_contract,simple_token_contract,token_contract,test_contract.ClaudeBox log: https://claudebox.work/s/abba570993edc904?run=1