fix: handle empty or malformed logs during message processing (#21192)#21598
Merged
nchamo merged 3 commits intoMar 16, 2026
Merged
Conversation
Adapted to staging branch API: - Keep staging's process_message_ciphertext signature (4 args, no process_custom_message) - Keep staging's do_sync_state signature (3 params with offchain_inbox_sync) - Remove CustomMessageHandler references from test (not present on staging) - Add empty log guard with warn_log_format using macro-based logging
ca67c35 to
3092f0c
Compare
nchamo
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21192 to v4-next.
Cherry-pick of 9cc2833 with conflict resolution to adapt to staging branch API differences:
aztecnr_debug_log_format!/aztecnr_warn_log_format!(staging style)do_sync_statesignature (3 params withoffchain_inbox_sync)process_message_ciphertextsignature (4 args, noprocess_custom_message)aztec_utl_aes128Decryptmethod nameCustomMessageHandlerreferences not present on staging)Changes backported
AES128::decryptreturnsOption::none()instead of panicking on malformed ciphertextdo_sync_stateskips empty logs instead of panickingtry_fields_from_bytesnon-panicking conversion function