Skip to content

refactor: forbid globally scoped capsules#21614

Merged
mverzilli merged 49 commits into
martin/scoped-capsulesfrom
martin/capsule-arrays-scope-up-1
Mar 24, 2026
Merged

refactor: forbid globally scoped capsules#21614
mverzilli merged 49 commits into
martin/scoped-capsulesfrom
martin/capsule-arrays-scope-up-1

Conversation

@mverzilli

@mverzilli mverzilli commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Depends on #21588

Uses the new scoped functionalities of capsules from as many places in the codebase as possible

Note: this PR makes the distinction between stored capsules and volatile arrays even more painfully clear, as capsules used just for rpc comms between Aztec.nr and PXE don't really need a scope but at the same time would be better off not being global to remove concurrency constraints

Closes F-459

@mverzilli mverzilli changed the title Martin/capsule arrays scope up 1 refactor: default to scoped capsule arrays Mar 16, 2026
@mverzilli mverzilli marked this pull request as ready for review March 16, 2026 17:15
@mverzilli mverzilli requested a review from nventuro as a code owner March 16, 2026 17:15
@mverzilli mverzilli removed the request for review from nventuro March 16, 2026 17:15
Comment thread noir-projects/aztec-nr/aztec/src/messages/processing/offchain.nr
Comment thread yarn-project/pxe/src/pxe.ts
Comment thread yarn-project/pxe/src/contract_sync/contract_sync_service.ts
Comment thread noir-projects/aztec-nr/aztec/src/messages/processing/offchain.nr
@mverzilli mverzilli requested review from nventuro and removed request for nventuro March 17, 2026 12:04
@mverzilli mverzilli changed the title refactor: default to scoped capsule arrays refactor: forbid globally scoped capsules Mar 19, 2026
Comment thread noir-projects/aztec-nr/aztec/src/macros/aztec.nr
Comment thread noir-projects/aztec-nr/aztec/src/macros/aztec.nr
Comment thread noir-projects/aztec-nr/aztec/src/messages/processing/mod.nr Outdated
Comment thread noir-projects/aztec-nr/aztec/src/test/helpers/test_environment.nr Outdated
Comment thread yarn-project/end-to-end/src/e2e_offchain_effect.test.ts
Comment thread yarn-project/pxe/src/logs/log_service.ts Outdated
Comment thread yarn-project/pxe/src/pxe.ts
Comment thread yarn-project/pxe/src/storage/capsule_store/capsule_store.ts Outdated
Base automatically changed from martin/default-to-scoped-capsules to martin/scoped-capsules March 23, 2026 11:31
Comment thread noir-projects/aztec-nr/aztec/src/messages/discovery/mod.nr
Comment thread noir-projects/aztec-nr/aztec/src/macros/aztec.nr
Comment thread noir-projects/aztec-nr/aztec/src/capsules/mod.nr Outdated
Comment thread noir-projects/aztec-nr/aztec/src/capsules/mod.nr Outdated
@mverzilli mverzilli merged commit 1284cc1 into martin/scoped-capsules Mar 24, 2026
11 checks passed
@mverzilli mverzilli deleted the martin/capsule-arrays-scope-up-1 branch March 24, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants