Skip to content

fix: update nullifier non-inclusion test expectations after early oracle throw (backport #21600)#21615

Merged
benesjan merged 4 commits into
backport-to-v4-next-stagingfrom
claudebox/backport-21600-v4-next
Mar 17, 2026
Merged

fix: update nullifier non-inclusion test expectations after early oracle throw (backport #21600)#21615
benesjan merged 4 commits into
backport-to-v4-next-stagingfrom
claudebox/backport-21600-v4-next

Conversation

@AztecBot

@AztecBot AztecBot commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Backport of #21600 to v4-next.

Updates 5 should_fail_with test expectations from "Proving nullifier non-inclusion failed" to "Cannot prove nullifier non-inclusion", plus a nargo fmt fix (0 -> 0_u64).

Conflict Resolution

One conflict in delayed_public_mutable_values/test.nr: the ScheduledDelayChange generic parameter was <0> on v4-next vs <0_u64> in the PR. Resolved by accepting the nargo fmt fix.

Commits

  1. Cherry-pick with conflicts — raw cherry-pick output preserved for review
  2. Conflict resolution — accepted 0_u64 nargo fmt fix

Files changed

  • noir-projects/aztec-nr/aztec/src/history/note/test.nr (1 test)
  • noir-projects/aztec-nr/aztec/src/history/nullifier/test.nr (2 tests)
  • noir-projects/noir-contracts/contracts/test/test_contract/src/test/deployment_proofs.nr (2 tests)
  • noir-projects/noir-protocol-circuits/crates/types/src/delayed_public_mutable/delayed_public_mutable_values/test.nr (nargo fmt)

ClaudeBox log: https://claudebox.work/s/8656d18924944b84?run=1

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label Mar 16, 2026
@AztecBot AztecBot force-pushed the claudebox/backport-21600-v4-next branch 2 times, most recently from 918eb5b to 37ce880 Compare March 16, 2026 17:31
@nchamo nchamo marked this pull request as ready for review March 16, 2026 17:33
@nchamo nchamo requested a review from nventuro as a code owner March 16, 2026 17:33
@nchamo nchamo self-assigned this Mar 16, 2026
@nchamo nchamo force-pushed the claudebox/backport-21600-v4-next branch from 37ce880 to 4e9180e Compare March 17, 2026 15:01
nchamo and others added 2 commits March 17, 2026 15:11
…ter early oracle throw (with conflicts)

Cherry-pick of 9613420 from PR #21600.
Conflict in delayed_public_mutable_values/test.nr preserved for review.
Resolved conflict in delayed_public_mutable_values/test.nr by accepting the
nargo fmt fix (0 -> 0_u64).
@AztecBot AztecBot force-pushed the claudebox/backport-21600-v4-next branch from 4e9180e to 7215514 Compare March 17, 2026 15:12
@AztecBot AztecBot requested a review from LeilaWang as a code owner March 17, 2026 15:12
@AztecBot AztecBot changed the title fix: backport #21600 — update nullifier non-inclusion test expectations (v4-next) fix: update nullifier non-inclusion test expectations after early oracle throw (backport #21600) Mar 17, 2026
@benesjan benesjan enabled auto-merge (squash) March 17, 2026 15:20
@benesjan benesjan merged commit 5a9a795 into backport-to-v4-next-staging Mar 17, 2026
9 checks passed
@benesjan benesjan deleted the claudebox/backport-21600-v4-next branch March 17, 2026 16:25
AztecBot added a commit that referenced this pull request Mar 19, 2026
BEGIN_COMMIT_OVERRIDE
feat: entrypoint replay protection (#21649)
feat: guard BoundedVec oracle returns against dirty trailing storage
(#21589)
fix: add bounds when allocating arrays in deserialization (#21622)
feat: implement manual Packable for structs with sub-Field members
(#21576)
fix(aztec-node): throw on existing nullifier in
getLowNullifierMembershipWitness (#21472)
fix: use trait dispatch for array Packable::unpack in card_game_contract
(#21683)
fix(p2p): penalize peers for errors during response reading (#21680)
fix: update nullifier non-inclusion test expectations after early oracle
throw (backport #21600) (#21615)
fix(aztec-nr): fix OOB index with nonzero offset (#21613)
fix(builder): persist contractsDB across blocks within a checkpoint
(#21520)
fix(stdlib): accept null return_type for void Noir functions (#21647)
feat: gas estimations on send (#21646)
fix(validator): process block proposals from own validator keys in HA
setups (backport #21603) (#21659)
fix(p2p): penalize peer on tx rejected by pool (#21677)
fix(sequencer): fix checkpoint budget redistribution for multi-block
slots (#21692)
feat: sync cache invalidation oracle (backport #21459) (#21730)
feat!: make AES128 decrypt oracle return Option (backport #21696)
(#21735)
feat!: include init_hash in private initialization nullifier (backport
#21427) (#21736)
fix(sequencer): extract gas and blob configs from valid requests only
(A-677) (#21747)
chore: backport #21744 — replace dead BOOTSTRAP_TO env var with
bootstrap.sh build arg (#21748)
refactor: revert remove assert_bounded_vec_trimmed (#21758)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants