fix: last block in the checkpoints gets ramaining gas limits#21669
Closed
alexghr wants to merge 1 commit into
Closed
fix: last block in the checkpoints gets ramaining gas limits#21669alexghr wants to merge 1 commit into
alexghr wants to merge 1 commit into
Conversation
alexghr
commented
Mar 17, 2026
| // minValidTxs is passed into the builder so it can reject the block *before* updating state. | ||
| const minValidTxs = forceCreate ? 0 : (this.config.minValidTxsPerBlock ?? minTxs); | ||
| const blockBuilderOptions: PublicProcessorLimits & { minValidTxs?: number } = { | ||
| maxTransactions: this.config.maxTxsPerBlock, |
Contributor
Author
There was a problem hiding this comment.
I wasn't sure if this could be safely set to undefined when isLastBlock.
Contributor
Author
|
closing as it got fixed in #21692 |
auto-merge was automatically disabled
April 1, 2026 12:08
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.