chore: Backport to v4 staging#21714
Merged
Merged
Conversation
…e tag (A-686) (#21687) (with conflicts)
…ProposedBlocks API
…entire tag (A-686) (#21713) ## Summary Backport of #21687 to v4. During reorg, `deleteLogs` was deleting the entire log entry for a tag instead of only removing logs from the rolled-back blocks. This caused logs from earlier blocks to be lost. ## Cherry-pick conflicts The automatic cherry-pick failed due to API differences between `next` and `v4`: - `next` uses `store.addProposedBlock(block)` (singular) — v4 uses `store.addProposedBlocks([block])` (plural, takes array) - `next` uses a helper `addProposedBlocks(store, ...)` — adapted to call `store.addProposedBlocks(...)` directly in v4 ## Commit structure 1. **Cherry-pick with conflicts** — raw cherry-pick preserving conflict markers 2. **Conflict resolution** — adapted `addProposedBlock` → `addProposedBlocks` API calls Fixes https://linear.app/aztec-labs/issue/A-686 ClaudeBox log: https://claudebox.work/s/1f9640fef77e1838?run=2
ludamad
requested review from
a team,
IlyasRidhuan,
LHerskind,
LeilaWang,
Maddiaa0,
charlielye,
dbanks12,
fcarreiro,
jeanmon,
just-mitch,
nventuro and
sirasistant
as code owners
## Summary
Testnet validators were detecting inactive validators and starting
slashing rounds, but all votes were computed as zero because the
per-offense penalty (`10e18` = 10 TST) was far below the L1 contract's
minimum slash threshold (`100000e18` = 100,000 TST).
This PR sets all testnet slashing penalty values to `100000e18` to match
`AZTEC_SLASH_AMOUNT_SMALL`, which is the minimum amount needed for a
vote to register as 1 slash unit.
## Root Cause
The vote computation in `getSlashUnitsForAmount()`
(`yarn-project/stdlib/src/slashing/tally.ts`) checks if the accumulated
offense amount reaches `slashingAmounts[0]` (=
`AZTEC_SLASH_AMOUNT_SMALL`). Since `10e18 < 100000e18`, the function
always returned 0 slash units, causing all votes to be skipped.
## BigInt Parsing Verification
- The penalty values flow through env vars as strings (e.g.
`"100000e18"`)
- `bigintConfigHelper` in `foundation/src/config/index.ts` handles
scientific notation losslessly using bigint arithmetic (not float64)
- The parsing regex correctly handles `100000e18` → `BigInt("100000") *
10n ** 18n` = exact result
## Changes
- `spartan/environments/network-defaults.yml`: Updated all testnet
`SLASH_*_PENALTY` values from `10e18` to `100000e18`
ClaudeBox log: https://claudebox.work/s/a2a0d7830a3d8ce3?run=2
---------
Co-authored-by: ludamad <adam.domurad@gmail.com>
Co-authored-by: Amin Sammara <84764772+aminsammara@users.noreply.github.com>
aminsammara
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.