fix(p2p): update batch_tx_requester tests to use RequestTracker#21742
Closed
AztecBot wants to merge 1 commit into
Closed
fix(p2p): update batch_tx_requester tests to use RequestTracker#21742AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
…ad of removed MissingTxsTracker PR #21496 replaced MissingTxsTracker with RequestTracker and removed the deadline constructor arg, but 3 test cases in the smart/dumb peer promotion section still used the old API.
AztecBot
added
ci-draft
Maddiaa0
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #21496 (race condition fix) replaced
MissingTxsTrackerwithRequestTrackerand folded thedeadlineconstructor arg into the tracker, but 3 test cases in the smart/dumb peer promotion section still used the old API.This caused
yarn tsgo -b --emitDeclarationOnlyto fail with:TS2304: Cannot find name 'MissingTxsTracker'TS2554: Expected 4-7 arguments, but got 8Fixed by updating the 3 remaining test instances to use
RequestTracker.create(missing, new Date(Date.now() + deadline))and removing the extradeadlineargument, matching the pattern used in all other tests in the file.ClaudeBox log: https://claudebox.work/s/57f93c63da9994b6?run=1