Skip to content

fix: use architecture-aware ldid binary for ARM64 CI runners#21777

Open
AztecBot wants to merge 1 commit into
nextfrom
claudebox/fix-alpha-canary-ci
Open

fix: use architecture-aware ldid binary for ARM64 CI runners#21777
AztecBot wants to merge 1 commit into
nextfrom
claudebox/fix-alpha-canary-ci

Conversation

@AztecBot

@AztecBot AztecBot commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix canary CI failure on ARM64 (Graviton r7g) instances where ldid_linux_x86_64 cannot execute
  • Changed all ldid installation paths to use ldid_linux_$(uname -m) to download the correct binary for the host architecture (x86_64 or aarch64)
  • Made ldid -S failure non-fatal in inject_version (matching the existing codesign || true pattern for macOS)

Root Cause

Release CI ran on r7g.16xlarge (ARM64 Graviton) but ldid was hardcoded to ldid_linux_x86_64 in all installation paths, causing "Exec format error" during macOS cross-compilation signing.

Details

Test plan

  • CI release build passes on ARM64 Graviton instances
  • macOS cross-compiled binaries are properly signed with ldid when available

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Mar 19, 2026
@AztecBot

Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/8dd3c4f80475c32c�8dd3c4f80475c32c8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_mbps.pipeline.parallel.test.ts "pipelining builds blocks using slot plus 1 proposer and proves them" (270s) (code: 0) group:e2e-p2p-epoch-flakes

@ludamad ludamad marked this pull request as ready for review March 19, 2026 02:51
@ludamad ludamad enabled auto-merge March 19, 2026 02:51
@ludamad ludamad added this pull request to the merge queue Mar 19, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 19, 2026
@AztecBot AztecBot force-pushed the claudebox/fix-alpha-canary-ci branch from e700b8a to 7871d30 Compare March 24, 2026 22:26
@AztecBot AztecBot requested a review from charlielye as a code owner March 24, 2026 22:26
@AztecBot AztecBot changed the title fix: cast size_t to unsigned int in write_frame for Windows cross-compile fix: use arch-aware ldid binary for ARM64 CI runners Mar 24, 2026
@AztecBot AztecBot force-pushed the claudebox/fix-alpha-canary-ci branch from 7871d30 to f064d34 Compare March 25, 2026 19:09
@AztecBot AztecBot changed the title fix: use arch-aware ldid binary for ARM64 CI runners fix: use arch-appropriate ldid binary for macOS cross-compile signing Mar 25, 2026
@AztecBot AztecBot force-pushed the claudebox/fix-alpha-canary-ci branch from f064d34 to e695dea Compare March 26, 2026 04:36
@AztecBot AztecBot changed the title fix: use arch-appropriate ldid binary for macOS cross-compile signing fix: make ldid ad-hoc signing non-fatal in bb cross-compilation Mar 26, 2026
@AztecBot AztecBot force-pushed the claudebox/fix-alpha-canary-ci branch from e695dea to ddfb682 Compare March 26, 2026 21:28
@AztecBot AztecBot changed the title fix: make ldid ad-hoc signing non-fatal in bb cross-compilation fix: use architecture-aware ldid binary for ARM64 CI runners Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants