Skip to content

fix(aztec-up): narrow PATH cleanup regex to avoid removing user PATH entries#21828

Merged
nchamo merged 1 commit into
merge-train/fairiesfrom
fix/aztec-install-path-regex
Mar 23, 2026
Merged

fix(aztec-up): narrow PATH cleanup regex to avoid removing user PATH entries#21828
nchamo merged 1 commit into
merge-train/fairiesfrom
fix/aztec-install-path-regex

Conversation

@nchamo

@nchamo nchamo commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Problem

The update_path_env_var function in aztec-install uses a broad regex to clean up old aztec PATH entries from the user's shell profile:

grep -Ev 'export PATH=.*/\.aztec/' "$shell_profile"

This matches any export PATH= line containing /.aztec/ anywhere, which means it silently removes user-written PATH lines that happen to include .aztec directories. For example, a user with:

export PATH="/usr/local/bin:$HOME/.aztec/bin:$HOME/go/bin:$PATH"

would have this line deleted every time they run the installer, losing their /usr/local/bin and $HOME/go/bin entries.

PATH formats found in git history

The installer has written two formats over time:

  1. Old format (pre-version-manager, 5a80cd7adf): export PATH="$PATH:$HOME/.aztec/bin" — appends aztec to PATH
  2. Current format (since f69c7bfe67): export PATH="$HOME/.aztec/current/bin:$HOME/.aztec/current/node_modules/.bin:$HOME/.aztec/bin:$PATH" — prepends aztec to PATH

Both need to be cleaned up on re-install. Neither should cause collateral damage to user lines.

Fix

Replace the broad regex with a targeted alternation that only matches the two known installer-written formats:

grep -Ev 'export PATH="\$(HOME/\.aztec/|PATH:.*\.aztec/)' "$shell_profile"

This matches:

  • export PATH="$HOME/.aztec/... — current format (PATH value starts with $HOME/.aztec/)
  • export PATH="$PATH:.../.aztec/... — old format (PATH value starts with $PATH: and contains /.aztec/)

And does not match user lines like:

  • export PATH="/usr/local/bin:$HOME/.aztec/bin:$HOME/go/bin:$PATH" (doesn't start with $HOME/.aztec or $PATH:)
  • export PATH="$HOME/.local/bin:$HOME/.aztec/bin:$PATH" (starts with $HOME/.local, not $HOME/.aztec)
  • export PATH="$HOME/.aztec-tools/bin:$PATH" (trailing / after .aztec prevents matching .aztec-tools)

Fixes F-470

@nchamo nchamo requested a review from charlielye as a code owner March 19, 2026 23:35
@nchamo nchamo self-assigned this Mar 19, 2026
@nchamo nchamo requested review from mverzilli and nventuro March 19, 2026 23:40

@mverzilli mverzilli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes this was a nasty one, good thing you're fixing it

@nchamo nchamo merged commit 2343ec8 into merge-train/fairies Mar 23, 2026
13 checks passed
@nchamo nchamo deleted the fix/aztec-install-path-regex branch March 23, 2026 13:51
@AztecBot

Copy link
Copy Markdown
Collaborator

✅ Successfully backported to backport-to-v4-next-staging #21899.

github-merge-queue Bot pushed a commit that referenced this pull request Mar 24, 2026
BEGIN_COMMIT_OVERRIDE
fix: explicitly handle initial block case for
getBlockHashMembershipWitness (#21836)
fix(aztec-up): narrow PATH cleanup regex to avoid removing user PATH
entries (#21828)
fix: use anchor block on getL1ToL2MsgWitness (#21872)
fix: make sure queries are not made ahead of the anchor block (#21874)
fix(aztec-up): strip leading `v` prefix from version strings (#21813)
END_COMMIT_OVERRIDE
AztecBot added a commit that referenced this pull request Mar 25, 2026
BEGIN_COMMIT_OVERRIDE
fix(aztec-up): narrow PATH cleanup regex to avoid removing user PATH
entries (#21828)
fix: consolidate blob source test into single summary log with supernode
detection (#21719)
fix: use anchor block on getL1ToL2MsgWitness (#21872)
fix: make sure queries are not made ahead of the anchor block (#21874)
chore(docs): backport docs infrastructure changes to v4 (#21437)
chore: backport PR #21836 (fix: explicitly handle initial block case for
getBlockHashMembershipWitness) to v4-next (#21891)
chore: backport PR #21813 (fix(aztec-up): strip leading v prefix from
version strings) to v4-next (#21912)
docs: document defi-wonderland immutable macro (#21764)
fix: pin typescript and harden lockfile check in docs examples CI (v4
backport) (#21914)
docs: expand circuit profiling guide and document kernel gate cost
overhead (#21770)
feat: cli-wallet (#21757)
chore: sync backport staging with v4-next HEAD (#21931)
fix: bot gas estimations (backport #21945) (#21947)
refactor(aztec-nr): use logging wrappers in
compute_note_hash_and_nullifier (#21897)
fix: backport v4 next staging (#21934)
fix: make PXE#getSyncedBlockHeader a concurrency=1 job to prevent IDB tx
liveness issues (#21944)
feat: add error page mapping for incompatible oracles (#21943)
fix(aztec-up): validate semver in uninstall to prevent path traversal
(#21892)
chore: merge v4-next into backport staging (fix ancestry) (#21954)
fix(aztec-up): add truncation protection to install scripts (#21896)
fix: noir format in compute_note_hash_and_nullifier.nr (#21956)
fix(stdlib): decode `EthAddress`, `FunctionSelector` and wrapped field
structs in `AbiDecoder` (#21926)
chore: update noir to nightly-2026-02-12-patch.1 (#21960)
fix: ensure empty docs examples does not populate yarn lock backport
(#21963)
fix: docs examples does not build on simple bootstrap backport (#21964)
fix: add rc/testnet version detection to API reference pages (#21966)
docs: document EmbeddedWallet automatic gas estimation and private
authwits (#21790)
fix(pxe): robust error handling in message processing (backport #21093)
(#21981)
chore: manually recreate backport (#21969)
chore: (A-779) load all accounts before calling
LogService.#getSecretsForSenders (#21923)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants