feat: merge-train/barretenberg#21879
Merged
Merged
Conversation
Resolves AztecProtocol/barretenberg#1373 and AztecProtocol/barretenberg#1367 Cleans up `TranslatorCircuitBuilder` and `TranslatorCircuitChecker`: 1. **Checker uses relations**: replaces the hand-rolled check() with the same relation-based pattern used by ultra circuit checker, populates `TranslatorFlavor::AllValues` per row and calls `accumulate` for `OpcodeConstraint`, `AccumulatorTransfer`, `Decomposition`, and `NonNativeField` relations. `PermutationRelation` and `DeltaRangeConstraintRelation` are intentionally skipped (require grand-product polynomials unavailable at circuit-builder level). 2. **Builder**: extracts 7 anonymous lambdas (`split_limb_into_microlimbs`, `split_wide_limb_into_2_limbs`, `uint512_to_limbs`, `check_binary_limbs_maximum_values`, `check_micro_limbs_maximum_values`, `lay_limbs_in_row`, `process_random_op`) into named private methods. 3. **Checker cleanup**: removes the intermediate `RelationInputs` struct and `compute_relation_inputs_limbs` helper.
resolves AztecProtocol/barretenberg#1383 While filling the wire polynomials in translator, we currently process wires sequentially (and parallelise filling an individual wire). However, since there's only $2^{13}$ values to be filled, it didn't make sense to parallelise for a given wire. Instead, we parallelise across wires: thread $i$ will process wire $i$. This makes the proving key construction faster by ~30% (but overall translator proving only improves by a mere ~2% because proving key construction forms a small part of total proving.)
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: translator checker and builder cleanup (#21094)
chore: better parallelisation of translator wire instantiation (#21100)
END_COMMIT_OVERRIDE