fix: address PR #21823 review comments (promiseWithResolvers, listener cleanup)#21898
Closed
AztecBot wants to merge 1 commit into
Closed
fix: address PR #21823 review comments (promiseWithResolvers, listener cleanup)#21898AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
AztecBot
added
ci-draft
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses post-merge review comments from #21823:
promiseWithResolversfrom foundation instead of manual Promise constructor inBatchChonkVerifier.enqueueProof(alexghr)FifoFrameReader.stop()to prevent memory leaks (alexghr)Other comments were already addressed (concurrency default=6) or no longer applicable (pinned hash removed).
Full analysis: https://gist.github.com/AztecBot/b3c5afd7ae842758e3039ee5a8c342b6
Test plan
yarn buildcompilesClaudeBox log: https://claudebox.work/s/820ad2fe44664e4c?run=2