fix(docs): remove stale @ts-expect-error directives in docs examples#21928
Closed
benesjan wants to merge 1 commit into
Closed
fix(docs): remove stale @ts-expect-error directives in docs examples#21928benesjan wants to merge 1 commit into
benesjan wants to merge 1 commit into
Conversation
…nd token_bridge The viem type inference for JSON-imported ABIs now works correctly with @aztec/viem@2.38.2, making these @ts-expect-error directives unused and causing TS2578 build errors in the docs examples validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
Affected files
All directives had the same comment: |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Author
|
Closing as I was retarded and didn't manage to read #enginnering channel where it was written that there is already a fix on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Docs build was broken and it resulted in flakes in 2 of my other PRs:
EthAddress,FunctionSelectorand wrapped field structs inAbiDecoder#21926I am not exactly sure why this happened but the changes here seem harmless so I think we can just merge this to not cause pain to other people today.
AI Summary
@ts-expect-errordirectives fromdocs/examples/ts/example_swap/index.ts@ts-expect-errordirectives fromdocs/examples/ts/token_bridge/index.tsThese directives were suppressing viem type inference errors for JSON-imported ABIs, but
@aztec/viem@2.38.2now handles this correctly. The stale directives causeTS2578: Unused '@ts-expect-error' directiveerrors during the docs examples validation pipeline (docs/bootstrap.sh).Test plan
example_swappassestsc --noEmitlocallytoken_bridgepassestsc --noEmitlocally🤖 Generated with Claude Code