fix: suppress debug assertions during mock IVC VK generation#21932
Closed
AztecBot wants to merge 1 commit into
Closed
fix: suppress debug assertions during mock IVC VK generation#21932AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
AztecBot
added
ci-draft
The nightly barretenberg debug build fails in test_chonk_standalone_vks_havent_changed.sh
because BB_ASSERT_DEBUG(kernel_return_data_match) fires in chonk.cpp when using mock IVC
data for VK generation. The mock data has intentionally mismatched dummy calldata
commitments ({1, 2}) that don't match the kernel_return_data from proof public inputs.
Fix: use BB_DISABLE_ASSERTS() guard when processing HN recursion constraints with mock IVC
(ivc_base == nullptr), which is the VK generation path. These databus consistency checks
are only meaningful with real witness data, not the dummy values used during VK derivation.
AztecBot
force-pushed
the
claudebox/fix-bb-debug-build
branch
from
6c8891f to
1e5b898
Compare
Contributor
|
Fixed in #21957 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nightly barretenberg debug build failure in
test_chonk_standalone_vks_havent_changed.sh.The VK check script uses
bb check --scheme chonkwith the debug-built binary. During VK generation, when no real IVC instance is available (ivc_base == nullptr), a mock IVC is created with dummy data. The mock's calldata commitments ({1, 2}) don't match thekernel_return_datafrom proof public inputs, triggeringBB_ASSERT_DEBUG(kernel_return_data_match)inchonk.cpp:173. This assertion is a no-op in release builds but crashes the debug binary.Fix: add
BB_DISABLE_ASSERTS()guard when processing HN recursion constraints with mock IVC data, since databus consistency checks are only meaningful with real witness data.CI log
kernel_return_data mismatch: proof contains { 0x2de8... } but calldata commitment is { 0x01, 0x02 }ClaudeBox log: https://claudebox.work/s/3bdb56bf04e64c5d?run=1