fix: add missing default cases in treeId switch statements#21942
Merged
PhilWindle merged 1 commit intoMar 24, 2026
Merged
Conversation
Three switch statements in nodejs_module/world_state/world_state.cpp (find_leaf_indices, find_sibling_paths, append_leaves) were missing default cases, causing silent failures on unknown treeId values instead of throwing errors.
Maddiaa0
approved these changes
Mar 24, 2026
PhilWindle
deleted the
phil/a-858-missing-default-in-switch-on-treeid-in-world_state
branch
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
BEGIN_COMMIT_OVERRIDE chore: deflake n_tps benchmark for LOW_VALUE_TPS=2 (#21578) fix(sequencer): use wall-clock timestamp for simulation when pipelining is disabled (#21888) fix: disable caching of error responses (300-499) on R2 custom domain (#21939) fix: add missing default cases in treeId switch statements (#21942) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default:cases to 3 switch statements ontreeIdinnodejs_module/world_state/world_state.cppfind_leaf_indices,find_sibling_paths,append_leavestreeIdvalues silently fell through instead of throwing errorsFixes A-858