chore: backport honk verifier opt fixes to v4 by saleel · Pull Request #21967 · AztecProtocol/aztec-packages

saleel · 2026-03-24T17:23:22Z

Backport #20547

Optimized verifier has a templating error - denominator inverses should not have started at the scratch space pointer used in the other bary centric values loop before, rather continued on from pointer Co-authored-by: Alejo Amiras <alejo.amiras@gmail.com> Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Ary Borenszweig <asterite@gmail.com> Co-authored-by: Charlie <5764343+charlielye@users.noreply.github.com> Co-authored-by: Charlie Lye <5764343+charlielye@users.noreply.github.com> Co-authored-by: Ciara Nightingale <ciara.nightingale@sky.com> Co-authored-by: DanielKotov <159419107+DanielKotov@users.noreply.github.com> Co-authored-by: DanielKotov <katod.daniel@gmail.com> Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com> Co-authored-by: Esau <esau@aztecprotocol.com> Co-authored-by: Facundo <fcarreiro@users.noreply.github.com> Co-authored-by: Ilyas Ridhuan <ilyas@aztecprotocol.com> Co-authored-by: IlyasRidhuan <ilyasridhuan@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Jan Beneš <janbenes1234@gmail.com> Co-authored-by: Jean M <132435771+jeanmon@users.noreply.github.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: Jonathan Hao <jonathanpohsianghao@gmail.com> Co-authored-by: Josh Crites <jc@joshcrites.com> Co-authored-by: José Pedro Sousa <jose@aztecprotocol.com> Co-authored-by: José Pedro Sousa <outgoing@zpedro.dev> Co-authored-by: Khashayar Barooti <khashayar@aztecprotocol.com> Co-authored-by: LHerskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: Leila Wang <leizciw@gmail.com> Co-authored-by: Lucas Xia <lucasxia01@gmail.com> Co-authored-by: Miranda Wood <miranda@aztecprotocol.com> Co-authored-by: MirandaWood <58737490+MirandaWood@users.noreply.github.com> Co-authored-by: MirandaWood <miranda@aztecprotocol.com> Co-authored-by: Mitch <mitchell@aztecprotocol.com> Co-authored-by: Mitchell Tracy <mitchellftracy@gmail.com> Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> Co-authored-by: Phil Windle <philip.windle@gmail.com> Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com> Co-authored-by: PhilWindle <philip.windle@gmail.com> Co-authored-by: Ragnar <rodiondenmark@gmail.com> Co-authored-by: Raju Krishnamoorthy <krishnamoorthy@gmail.com> Co-authored-by: Rumata888 <isennovskiy@gmail.com> Co-authored-by: Santiago Palladino <santiago@aztec-labs.com> Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com> Co-authored-by: Santiago Palladino <spalladino@gmail.com> Co-authored-by: Sarkoxed <75146596+Sarkoxed@users.noreply.github.com> Co-authored-by: Sarkoxed <sarkoxed2013@yandex.ru> Co-authored-by: Savio <72797635+Savio-Sou@users.noreply.github.com> Co-authored-by: Savio-Sou <72797635+Savio-Sou@users.noreply.github.com> Co-authored-by: StoneMac65 <StoneMac65@gmail.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: Thunkar <5404052+Thunkar@users.noreply.github.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: TomAFrench <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: alejoamiras <2982991+alejoamiras@users.noreply.github.com> Co-authored-by: alexghr <3816165+alexghr@users.noreply.github.com> Co-authored-by: benesjan <13470840+benesjan@users.noreply.github.com> Co-authored-by: benesjan <janbenes1234@gmail.com> Co-authored-by: charlielye <5764343+charlielye@users.noreply.github.com> Co-authored-by: ciaranightingale <52419674+ciaranightingale@users.noreply.github.com> Co-authored-by: critesjosh <18372439+critesjosh@users.noreply.github.com> Co-authored-by: danielntmd <danielntmd@nethermind.io> Co-authored-by: dbanks12 <david@aztec-labs.com> Co-authored-by: defkit <84741533+defkit@users.noreply.github.com> Co-authored-by: fcarreiro <facundo@aztecprotocol.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: feltroid Prime <96737978+feltroidprime@users.noreply.github.com> Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com> Co-authored-by: iAmMichaelConnor <42943676+iAmMichaelConnor@users.noreply.github.com> Co-authored-by: iAmMichaelConnor <mike@aztecprotocol.com> Co-authored-by: iakovenkos <sergey.s.yakovenko@gmail.com> Co-authored-by: jeanmon <132435771+jeanmon@users.noreply.github.com> Co-authored-by: jeanmon <jean@aztec-labs.com> Co-authored-by: jewelofchaos9 <jewelofchaos9@gmail.com> Co-authored-by: jorem321 <jorgearce321@gmail.com> Co-authored-by: josh crites <critesjosh@gmail.com> Co-authored-by: josh crites <jc@joshcrites.com> Co-authored-by: just-mitch <68168980+just-mitch@users.noreply.github.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com> Co-authored-by: ledwards2225 <l.edwards.d@gmail.com> Co-authored-by: lucasxia01 <lucasxia01@gmail.com> Co-authored-by: ludamad <163993+ludamad@users.noreply.github.com> Co-authored-by: ludamad <adam.domurad@gmail.com> Co-authored-by: ludamad <domuradical@gmail.com> Co-authored-by: maramihali <mara@aztec-labs.com> Co-authored-by: mralj <11197201+mralj@users.noreply.github.com> Co-authored-by: mralj <nikola.mratinic@gmail.com> Co-authored-by: mverzilli <651693+mverzilli@users.noreply.github.com> Co-authored-by: nishatkoti <nishatkoti@gmail.com> Co-authored-by: nventuro <2530770+nventuro@users.noreply.github.com> Co-authored-by: saleel <13466197+saleel@users.noreply.github.com> Co-authored-by: saleel <saleel@saleel.xyz> Co-authored-by: sarkoxed <sarkoxed2013@yandex.ru> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: signorecello <20129824+signorecello@users.noreply.github.com> Co-authored-by: signorecello <github@zpedro.dev> Co-authored-by: sirasistant <5372114+sirasistant@users.noreply.github.com> Co-authored-by: sirasistant <sirasistant@gmail.com> Co-authored-by: sklppy <152162806+sklppy88@users.noreply.github.com> Co-authored-by: sklppy88 <152162806+sklppy88@users.noreply.github.com> Co-authored-by: spalladino <429604+spalladino@users.noreply.github.com> Co-authored-by: spypsy <6403450+spypsy@users.noreply.github.com> Co-authored-by: spypsy <spypsy@outlook.com> Co-authored-by: suyash67 <suyashnbagad1997@gmail.com> Co-authored-by: thunkar <gregojquiros@gmail.com> Co-authored-by: wildjos <13541715+wildjos@users.noreply.github.com> Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>

## Overview This has been submitted for audit already, so I've attempted to make the changes / optimizations as small as possible. I came across these while reading through it again for the zk verifier. Commits are squashed to please CI - however ive pushed them to a mirror so they still exist within the repository - removing a scalar mul which was being multiplied by 1 - 699c7e2 - LAGRANGE_FIRST is always (1,2), constant_term_acc is always multiplied by (1,2) so add the scalars together - 6f2c350 - the remaining are batching all inversions into the same modexp - 05217b8 - f1a5830 This pr will be squashed - see [md/honk-golf-all-commits](https://github.com/AztecProtocol/aztec-packages/tree/md/honk-golf-all-commits) for commit by commit break down Co-authored-by: Alejo Amiras <alejo.amiras@gmail.com> Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Ary Borenszweig <asterite@gmail.com> Co-authored-by: Charlie Lye <5764343+charlielye@users.noreply.github.com> Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com> Co-authored-by: Esau <esau@aztecprotocol.com> Co-authored-by: Facundo <fcarreiro@users.noreply.github.com> Co-authored-by: IlyasRidhuan <ilyasridhuan@gmail.com> Co-authored-by: Jean M <132435771+jeanmon@users.noreply.github.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: Jonathan Hao <jonathanpohsianghao@gmail.com> Co-authored-by: Josh Crites <jc@joshcrites.com> Co-authored-by: José Pedro Sousa <jose@aztecprotocol.com> Co-authored-by: José Pedro Sousa <outgoing@zpedro.dev> Co-authored-by: Khashayar Barooti <khashayar@aztecprotocol.com> Co-authored-by: LHerskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: Lucas Xia <lucasxia01@gmail.com> Co-authored-by: MirandaWood <miranda@aztecprotocol.com> Co-authored-by: Mitch <mitchell@aztecprotocol.com> Co-authored-by: Mitchell Tracy <mitchellftracy@gmail.com> Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com> Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com> Co-authored-by: PhilWindle <philip.windle@gmail.com> Co-authored-by: Raju Krishnamoorthy <krishnamoorthy@gmail.com> Co-authored-by: Rumata888 <isennovskiy@gmail.com> Co-authored-by: Santiago Palladino <santiago@aztec-labs.com> Co-authored-by: Sarkoxed <sarkoxed2013@yandex.ru> Co-authored-by: Savio <72797635+Savio-Sou@users.noreply.github.com> Co-authored-by: StoneMac65 <StoneMac65@gmail.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: benesjan <13470840+benesjan@users.noreply.github.com> Co-authored-by: benesjan <janbenes1234@gmail.com> Co-authored-by: critesjosh <18372439+critesjosh@users.noreply.github.com> Co-authored-by: danielntmd <danielntmd@nethermind.io> Co-authored-by: dbanks12 <david@aztec-labs.com> Co-authored-by: fcarreiro <facundo@aztecprotocol.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com> Co-authored-by: iAmMichaelConnor <mike@aztecprotocol.com> Co-authored-by: jeanmon <jean@aztec-labs.com> Co-authored-by: jewelofchaos9 <jewelofchaos9@gmail.com> Co-authored-by: josh crites <jc@joshcrites.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com> Co-authored-by: ledwards2225 <l.edwards.d@gmail.com> Co-authored-by: lucasxia01 <lucasxia01@gmail.com> Co-authored-by: ludamad <163993+ludamad@users.noreply.github.com> Co-authored-by: ludamad <adam.domurad@gmail.com> Co-authored-by: ludamad <domuradical@gmail.com> Co-authored-by: mralj <nikola.mratinic@gmail.com> Co-authored-by: nventuro <2530770+nventuro@users.noreply.github.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: sirasistant <sirasistant@gmail.com> Co-authored-by: thunkar <gregojquiros@gmail.com>

AztecBot · 2026-03-24T21:09:13Z

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/93d2297b1a9df57d�93d2297b1a9df57d8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_mbps.parallel.test.ts "deploys a contract and calls it in separate blocks within a slot" (173s) (code: 0) group:e2e-p2p-epoch-flakes

alexghr

IIUC the optimized Honk verifier is not used so this is safe to be backported

Maddiaa0 · 2026-03-25T17:59:14Z

IIUC the optimized Honk verifier is not used so this is safe to be backported

yep, switching is governed by this pr
#21840

Maddiaa0 and others added 2 commits March 24, 2026 16:04

saleel requested review from a team March 24, 2026 17:23

ludamad approved these changes Mar 24, 2026

View reviewed changes

saleel changed the title ~~(do_no_merge): chore: backport honk verifier opt fixes to v4~~ chore: backport honk verifier opt fixes to v4 Mar 24, 2026

fix: test mem

32b2456

alexghr approved these changes Mar 25, 2026

View reviewed changes

Merge branch 'v4-next' into saleel/backport-20547

5f8e5f6

saleel enabled auto-merge March 25, 2026 08:38

saleel merged commit 0711b81 into v4-next Mar 25, 2026
11 of 12 checks passed

saleel deleted the saleel/backport-20547 branch March 25, 2026 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: backport honk verifier opt fixes to v4#21967

chore: backport honk verifier opt fixes to v4#21967
saleel merged 4 commits into
v4-nextfrom
saleel/backport-20547

saleel commented Mar 24, 2026 •

edited

Loading

Uh oh!

AztecBot commented Mar 24, 2026 •

edited

Loading

Uh oh!

alexghr left a comment

Uh oh!

Uh oh!

Maddiaa0 commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

saleel commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AztecBot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Flakey Tests

Uh oh!

alexghr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Maddiaa0 commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

saleel commented Mar 24, 2026 •

edited

Loading

AztecBot commented Mar 24, 2026 •

edited

Loading