feat: iframe wallets sdk#21978
Merged
Merged
Conversation
…packages into gj/iframe_wallets_sdk
- Add schema parsing (parseWithOptionals) to iframe connection handler so serialized args are properly deserialized before calling wallet methods - Fix race condition in iframe discovery by registering message listener before appending iframe to DOM - Fix async iterator types in discovery session to satisfy TypeScript - Deduplicate DisconnectCallback type into shared types.ts - Use shared WalletInfo type instead of inline type literals - Fix various lint issues (no-misused-promises, require-await, jsdoc) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mverzilli
reviewed
Mar 25, 2026
mverzilli
reviewed
Mar 25, 2026
mverzilli
reviewed
Mar 25, 2026
mverzilli
approved these changes
Mar 25, 2026
AztecBot
force-pushed
the
gj/iframe_wallets_sdk
branch
from
387017a to
0cc4d9b
Compare
mverzilli
reviewed
Mar 25, 2026
Comment on lines
+34
to
+36
| type IteratorState = | ||
| | { status: 'discovering'; resolve: ((result: IteratorResult<WalletProvider>) => void) | null } | ||
| | { status: 'done' }; |
…king, union state
AztecBot
force-pushed
the
gj/iframe_wallets_sdk
branch
from
0cc4d9b to
5d31ab1
Compare
AztecBot
pushed a commit
that referenced
this pull request
Mar 26, 2026
Adds support for iframe wallets. This has been tested on gregoswap and demo-wallet, landing it on aztec-packages so it's available in nightlies for further development. Once stable, docs will follow!
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #22036. |
AztecBot
added a commit
that referenced
this pull request
Mar 26, 2026
BEGIN_COMMIT_OVERRIDE feat: iframe wallets sdk (#21978) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for iframe wallets. This has been tested on gregoswap and demo-wallet, landing it on aztec-packages so it's available in nightlies for further development.
Once stable, docs will follow!