fix: port nightly debug build VK check fix from merge-train to next#22038
Closed
AztecBot wants to merge 1 commit into
Closed
fix: port nightly debug build VK check fix from merge-train to next#22038AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the fix from #21957 (merged into
merge-train/barretenbergon March 24) tonext. The nightly debug build has been failing for 5+ consecutive days because this fix hasn't propagated yet.The
test_chonk_standalone_vks_havent_changed.shscript crashes when running with a debug-builtbbbinary. Mock IVC data used for VK generation has intentionally dummy calldata commitments that triggerBB_ASSERT_DEBUG(kernel_return_data_match)in chonk.cpp — a no-op in release builds but fatal in debug.Changes
--disable_assertsflag tobb checkcommand, which callsBB_DISABLE_ASSERTS()to convert assertions to warningsbb_presetand pass--disable_assertswhen preset isdebugCI log
http://ci.aztec-labs.com/ed339fd42baf768f
Analysis
https://gist.github.com/AztecBot/379b6f904b57ac007e147a4e62bbb5c1
ClaudeBox log: https://claudebox.work/s/f77b6fe9b88aab06?run=1