fix(pxe): warn when block header unavailable for proven/finalized events#22050
Merged
Conversation
7 tasks
benesjan
force-pushed
the
jb/pxe-warn-missing-block-header
branch
from
d9f299c to
8640ae3
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
commented
Mar 26, 2026
Comment on lines
-33
to
-39
| if f.has_named_attribute("noinitcheck") { | ||
| true | ||
| } else { | ||
| // #[only_self] functions automatically skip the initialization check as the check is assumed to be done by the | ||
| // calling external function or explicitly skipped. See only_self function docs for more details. | ||
| is_fn_only_self(f) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I did this code yesterday and then I recalled I could simplify it and it kept on bothering me
benesjan
commented
Mar 26, 2026
|
|
||
| this.log.debug(`Syncing PXE with the node`); | ||
| // Capture the promise locally so we always await the exact promise we created, even if this.isSyncing is modified | ||
| // between assignment and await (e.g. due to future refactors introducing a yield point). |
Contributor
Author
There was a problem hiding this comment.
This was not clear to me and AI helped me here to explain it so I added there a comment.
nchamo
approved these changes
Mar 26, 2026
nchamo
left a comment
nchamo
left a comment
Contributor
There was a problem hiding this comment.
Warnings are always appreciated 👐
Comment on lines
+33
to
+35
| // #[only_self] functions automatically skip the initialization check as the check is assumed to be done by the | ||
| // calling external function or explicitly skipped. See only_self function docs for more details. | ||
| f.has_named_attribute("noinitcheck") | is_fn_only_self(f) |
Contributor
There was a problem hiding this comment.
I'm curious about why this is necessary. only_self adds the noinitcheck attribute automatically. I assumed this meant that it would pass the f.has_named_attribute("noinitcheck") check
Contributor
Author
There was a problem hiding this comment.
This is because we don't want to force people to slap #[noinitcheck] on #[only_self] - we essentially want that to be implicit.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
benesjan
force-pushed
the
jb/pxe-warn-missing-block-header
branch
from
8640ae3 to
7472aa9
Compare
Contributor
Author
|
Sorry, forgot to squash this before merging |
Collaborator
|
❌ Failed to cherry-pick to |
AztecBot
pushed a commit
that referenced
this pull request
Apr 15, 2026
…nts (#22050) Improved logging based on audit finding 114 in #21500 + random improvements that I noticed could be done ## Summary - Adds warning logs in PXE block synchronizer when `getBlockHeader` returns null for `chain-proven` and `chain-finalized` events, instead of silently skipping the anchor update. - Aligns with the `chain-pruned` handler which already throws on missing headers. Closes #21500 .
benesjan
added a commit
that referenced
this pull request
Apr 15, 2026
…nts (backport #22050) (#22547) ## Summary Backport of #22050 to v4-next. Cherry-pick applied cleanly. The noir-projects change from the original PR was already present on v4-next, so only the PXE block_synchronizer changes were needed. ### Changes - Adds warning logs in PXE block synchronizer when `getBlockHeader` returns null for `chain-proven` and `chain-finalized` events, instead of silently skipping the anchor update - Adds a comment clarifying the local promise capture pattern in `sync()` ClaudeBox log: https://claudebox.work/s/017ec0a44d097055?run=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved logging based on audit finding 114 in #21500 + random improvements that I noticed could be done
Summary
getBlockHeaderreturns null forchain-provenandchain-finalizedevents, instead of silently skipping the anchor update.chain-prunedhandler which already throws on missing headers.Closes #21500 .