Skip to content

fix: use DateProvider in PeerScoring#22070

Merged
PhilWindle merged 1 commit into
merge-train/spartanfrom
spyros/a-879-peerscoring-should-use-dateprovider
Mar 26, 2026
Merged

fix: use DateProvider in PeerScoring#22070
PhilWindle merged 1 commit into
merge-train/spartanfrom
spyros/a-879-peerscoring-should-use-dateprovider

Conversation

@spypsy

@spypsy spypsy commented Mar 26, 2026

Copy link
Copy Markdown
Member

Injects a DateProvider into PeerScoring so that time is no longer read directly from Date.now(). This enables deterministic testing without relying on jest.useFakeTimers().

  • Add DateProvider as an optional third constructor parameter (defaults to new DateProvider() so existing call sites are unaffected)
  • Replace both Date.now() calls in updateScore and decayAllScores with this.dateProvider.now()
  • Rewrite tests to use ManualDateProvider for fully deterministic time control

Fixes A-879

Made with Cursor

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Made-with: Cursor
@spypsy spypsy changed the title fix: use DateProvider in PeerScoring instead of Date.now() fix: use DateProvider in PeerScoring Mar 26, 2026
@spypsy spypsy marked this pull request as ready for review March 26, 2026 17:22
@PhilWindle PhilWindle merged commit 77db977 into merge-train/spartan Mar 26, 2026
18 checks passed
@PhilWindle PhilWindle deleted the spyros/a-879-peerscoring-should-use-dateprovider branch March 26, 2026 22:06
github-merge-queue Bot pushed a commit that referenced this pull request Mar 27, 2026
BEGIN_COMMIT_OVERRIDE
fix: only clear provenBlockNumber when it exceeds prune point (#21946)
chore: (A-779) load all accounts before calling
LogService.#getSecretsForSenders (#21923)
fix: align staging-public mana target with testnet/mainnet (#21983)
chore: (A-777) add warn logs for regressive path in block synchronizer
(#21925)
fix: fully validate txs retrieved from tx file store (#21988)
refactor: extract checkpoint proposal handling to ProposalHandler
(#21999)
fix: unbounded memory in calldataRetriever (#22004)
fix(p2p): check peer rate limit before global to prevent quota
starvation (#21997)
fix(p2p): evict expired failed-auth-handshake entries on heartbeat
(#21992)
chore: defensively handle skipPushProposedBlocksToArchiver (#22017)
chore: bump testnet prover resource profile to prod-hi-tps (#22019)
chore: (A-835) remove unused serializer (#22037)
fix(p2p): remove disconnected peers from scoring maps (#22009)
fix(e2e): set anvilSlotsInAnEpoch in slashing tests (#21869)
fix(ethereum): Audit fixes A-810, A-812 (nonce race, isEscapeHatchOpen
logging) (#21948)
chore: remove old TxPool implementation (#22028)
fix: Fix blob encoding when uploaded from proposals (#22045)
chore: Adds /cycle and /fix skills. Also configures linear mcp server
(#22043)
chore: remove validatorReexecute config option (#22024)
fix(sequencer): use last L1 slot of L2 slot as eth_simulateV1 timestamp
(#22023)
docs(simulator): clarify teardown gas billing is intentional (#22057)
chore: revert account loading optimization in log service (#22062)
fix: use DateProvider in PeerScoring (#22070)
fix(aztec.js): preserve extraHashedArgs in DeployMethod.with() (#22053)
fix(p2p): replace process.exit() with graceful shutdown in worker
cleanup (#22046)
chore: merge next (#22089)
fix(stdlib): correct NoteDao size (#22068)
feat: improve blob download from filestores (#22096)
fix: remove stale tx_pool v1 benchmark reference (#22104)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants