fix: handle error event on SSH agent socket to prevent Node crash#22090
Merged
spypsy merged 1 commit intoMar 30, 2026
Conversation
…802) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Made-with: Cursor
PhilWindle
approved these changes
Mar 30, 2026
spypsy
deleted the
spyros/a-802-audit-145-ssh-agent-socket-never-handles-error-event-crashes
branch
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
BEGIN_COMMIT_OVERRIDE chore: setup snapshot retention rules (#22107) fix: add branding to Buffer16 and Buffer32 to prevent cross-type misuse (#22128) chore: (A-723) redact beacon api key in debug path (#22115) fix(archiver): use Buffer16.ZERO for rolling hash fallback in L1 synchronizer (#22133) feat(pipeline): allow syncing blocks ontop of the proposed chain (#21025) fix(logger): no arbitrary long logger module name (#22143) chore: setup workload identity for ESO (#22137) fix: Make test more robust to committee selection. (#22139) fix: handle error event on SSH agent socket to prevent Node crash (#22090) fix: disable SponsoredFPC on staging-public (#22150) fix(archiver): swallow error when rollup contract not yet finalized on L1 (#22156) chore: update dashboard (#22157) chore: switch testnet back to prod resource profile (#22159) chore: nightly scenario deployments should not be triggered by older images (#22148) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
getIdentities()andsignWithAgent()inssh_agent.tscreate anet.Socketbut never register anerrorevent handler. When the connection to the SSH agent fails (e.g.SSH_AUTH_SOCKpoints to a stale socket), the socket emits anerrorevent with no listener, causing Node.js to throw an unhandled exception and crash the process.The fix adds
stream.on('error', reject)to both promise constructors, so connection errors are correctly propagated as rejected promises instead of crashing the process.Fixes A-802
Made with Cursor