fix: add missing contractAddress param in log_service tests#22098
Merged
mverzilli merged 3 commits intoMar 27, 2026
Merged
Conversation
AztecBot
added
ci-draft
AztecBot
force-pushed
the
claudebox/fix-log-service-test-contract-address
branch
from
b3e053f to
6d85ae7
Compare
mverzilli
approved these changes
Mar 27, 2026
Collaborator
Author
|
❌ Failed to cherry-pick to |
AztecBot
added a commit
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchLogsByTagwas updated to takecontractAddressas a new first parameter, but 3 test cases were not updated to pass it.contractAddressargument to the 3 failingfetchLogsByTagcalls inlog_service.test.ts.CI failure
http://ci.aztec-labs.com/acee20999917508a
ClaudeBox log: https://claudebox.work/s/11d77dc66330b726?run=1