Skip to content

fix: skip ldid signing on ARM64 — macOS artifacts are only published from amd64#22120

Merged
alexghr merged 1 commit into
nextfrom
claudebox/fix-ldid-arch
Mar 30, 2026
Merged

fix: skip ldid signing on ARM64 — macOS artifacts are only published from amd64#22120
alexghr merged 1 commit into
nextfrom
claudebox/fix-ldid-arch

Conversation

@AztecBot

@AztecBot AztecBot commented Mar 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

The nightly Docker image build has been failing since March 25 because the ARM64 release instance tries to run ldid (an x86_64 Linux binary) to re-sign cross-compiled Mach-O binaries after version injection.

This was exposed by PR #21953 which fixed llvm-objdumpllvm-objdump-20, making Mach-O detection actually work — before that, the detection silently failed so ldid was never called.

Fix

Gate the ldid call behind $(arch) == amd64 in inject_version. The ARM64 instance doesn't need to sign Mach-O binaries because all macOS release artifacts are published exclusively from the amd64 instance:

  • GitHub releases (tarballs): packaged by build_release_dir, runs on amd64 only
  • bb.js npm packages: copy_cross.sh already guards ldid with [[ "$(arch)" == "amd64" ]]
  • Docker images: Linux binaries only, no Mach-O signing needed

The ARM64 instance builds cross targets (macOS, Windows, iOS, Android) to populate the shared build cache, but never publishes them.

Impact

Unblocks the nightly release pipeline → unblocks Deploy Next Net (failing 6 days).

Changed file

barretenberg/cpp/bootstrap.sh — one-line change in inject_version"

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Mar 28, 2026
@alexghr alexghr marked this pull request as ready for review March 28, 2026 10:12
@alexghr alexghr requested a review from charlielye as a code owner March 28, 2026 10:12
@alexghr alexghr added the ci-release-pr Creates a development tag and runs the release suite label Mar 28, 2026
@AztecBot AztecBot removed the ci-release-pr Creates a development tag and runs the release suite label Mar 28, 2026
@AztecBot AztecBot changed the title fix: install architecture-appropriate ldid binary for ARM64 CI fix: skip ldid signing on ARM64 — macOS artifacts are only published from amd64 Mar 30, 2026
@AztecBot AztecBot force-pushed the claudebox/fix-ldid-arch branch from 29e0b4a to 7845da5 Compare March 30, 2026 15:34
@alexghr alexghr enabled auto-merge March 30, 2026 15:51
@alexghr alexghr added this pull request to the merge queue Mar 30, 2026
Merged via the queue into next with commit c7172cb Mar 30, 2026
19 checks passed
@alexghr alexghr deleted the claudebox/fix-ldid-arch branch March 30, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants