chore: minor fixes pt. 3#22181
Merged
Merged
Conversation
iakovenkos
commented
Mar 31, 2026
ludamad
approved these changes
Mar 31, 2026
AztecBot
added a commit
that referenced
this pull request
Mar 31, 2026
create_mock_chonk_from_constraints was passing constraints.size() (1-2) to Chonk constructor which now requires >= 4 after #22181. The mock doesn't use num_circuits for anything, so passing max(size, 4) is safe.
iakovenkos
pushed a commit
that referenced
this pull request
Mar 31, 2026
…22188) ## Summary PR #22181 tightened the `Chonk` constructor to require `num_circuits >= 4`, but `create_mock_chonk_from_constraints()` was passing `constraints.size()` (1-2 for most kernels), causing assertion failures during VK generation for `mock-protocol-circuits` and `noir-protocol-circuits`. ## Fix Pass `std::max(constraints.size(), 4)` since the mock doesn't use `num_circuits` for anything — it directly manipulates the verification queue. ## Verification - All DSL tests pass (Hypernova, MockVerifier, ChonkRecursion) - `mock-protocol-circuits` bootstrap: 11/11 circuits pass - `noir-protocol-circuits` bootstrap: 120/120 circuits pass ClaudeBox log: https://claudebox.work/s/71d20ef48c81e6e3?run=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
triaging relations findings