fix: update aes128 decrypt test for PKCS#7 padding validation#22191
Closed
AztecBot wants to merge 1 commit into
Closed
fix: update aes128 decrypt test for PKCS#7 padding validation#22191AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Member
|
closing in favour of #22179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aes_encrypt_then_decrypt_with_bad_sym_key_is_caughttest was failing because PR fix(aes128): validate PKCS#7 padding in decryptBufferCBC #22179 added PKCS#7 padding validation to the AES128 decrypt oracle.Some(garbage)— the test relied on MAC comparison to detect bad decryption.Nonewhen padding is invalid (which happens with wrong-key decryption), so the.unwrap()call panicked before reaching the MAC check.try_aes128_decryptreturnsNonewith a bad key, and updated the doc comment to reflect the new behavior.Test plan
nargo checkcompiles cleanly with no errorsoracle::aes128_decrypt::test::aes_encrypt_then_decrypt_with_bad_sym_key_is_caughttestClaudeBox log: https://claudebox.work/s/4d7f4a8137228683?run=1