fix(archiver): always advance L1-to-L2 messages syncpoint to current L1 block (backport #22154)#22198
Closed
AztecBot wants to merge 5 commits into
Closed
Conversation
Remove unnecessary inboxTreeInProgress field, L1ToL2MessagesNotReadyError, and setMessageSyncState that were pulled from next but don't belong on v4-next. Use existing setMessageSynchedL1Block instead. Also removes accidental submodule deletions from the previous commit.
8b16bb8 to
54ab5b0
Compare
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
spalladino
approved these changes
Apr 7, 2026
…154-archiver-syncpoint
Contributor
|
Closing since won't need it for v4 |
auto-merge was automatically disabled
April 14, 2026 21:14
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #22154 to v4-next.
The L1-to-L2 messages syncpoint tracked the L1 block of the last downloaded message. If no messages were sent for a long time, the syncpoint got stuck and the next non-empty sync iteration re-scanned old block ranges. The syncpoint now always advances to
currentL1BlockNumberon success, with rollback-and-retry on mismatch.Cherry-pick conflicts
The automatic cherry-pick failed because v4-next was missing the
#inboxTreeInProgressfield andL1ToL2MessagesNotReadyErrorinfrastructure that existed onnextprior to PR #22154. These were added as part of the build-fix commit.Commit structure (3 commits):
#inboxTreeInProgressfield declaration and constructor initialization inMessageStoreL1ToL2MessagesNotReadyErrorerror class inerrors.tstreeInProgressguard ingetL1ToL2MessagesBuffer16,INITIAL_CHECKPOINT_NUMBER,L1ToL2MessagesNotReadyError)ClaudeBox log: https://claudebox.work/s/ace92e2ca7858f70?run=1