feat: disable noir test cache on merge-train/fairies#22206
Merged
ludamad merged 1 commit intoApr 1, 2026
Conversation
When TARGET_BRANCH is merge-train/fairies, use `disabled-cache` as the test hash for aztec-nr, noir-contracts, and noir-contracts-comp-failures. This ensures these tests always run on fairies PRs since yarn-project changes (e.g. TXE foreign call handlers) can affect test outcomes but are not included in the content hash. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ludamad
approved these changes
Apr 1, 2026
Collaborator
|
Looks right to me, good with you guys figuring out what works for you with noir-projects |
Contributor
Author
|
Thanks for the quick review @ludamad . Being able to do this indeed seems like a big benefit of merge trains 👍 |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
BEGIN_COMMIT_OVERRIDE feat!: remove ALL_SCOPES (#22136) chore: syncing oracle versions (#22131) fix(aztec-nr): use registered accounts as capsule test scopes (#22171) chore: reverting accidentally merged AI slop (#22175) feat: move event size check from declaration to private emission (#22168) fix: prevent oracle failure on tag computation for invalid recipient (#22163) feat: disable noir test cache on merge-train/fairies (#22206) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has happened a couple of times that we broke our merge train branch because we merged in a PR that had failing Noir tests and we broke them because we modified PXE/TXE. In this PR we set it up such that these tests are always run on our branch.
Summary
TARGET_BRANCHismerge-train/fairies, usedisabled-cacheas the test hash foraztec-nr,noir-contracts, andnoir-contracts-comp-failuresyarn-projectchanges (e.g. TXE foreign call handlers) can affect test outcomes but are not included in the content hashTest plan
🤖 Generated with Claude Code