fix: remove unused createDispatchFn with no method allowlist#22219
Merged
spalladino merged 1 commit intoApr 1, 2026
Conversation
The createDispatchFn function had zero callsites and allowed arbitrary method dispatch without validation. The only actual TransportServer usage already validates methods via schemaHasMethod. Remove the dead code and move the DispatchMsg type into create_dispatch_proxy.ts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
spalladino
approved these changes
Apr 1, 2026
spalladino
deleted the
phil/a-745-audit-73-arbitrary-method-dispatch-via-transport-no-method
branch
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
BEGIN_COMMIT_OVERRIDE chore: (A-771) remove dead code, verify keypair (#22167) fix(aes128): validate PKCS#7 padding in decryptBufferCBC (#22179) chore: (A-815) fix l1 tx utils fallback id logic (#22187) fix(archiver): always advance L1-to-L2 messages syncpoint to current L1 block (#22154) chore: (A-832) fix defaultFetch double consuming response on JSON parse failure (#22194) fix: indefinite retry for prover node and agent broker communication (#22202) fix: remove unused createDispatchFn with no method allowlist (#22219) chore: fix wallet setup to use NO_FROM instead of ZERO address (#22222) fix: update aes128 bad-key test for PKCS#7 padding validation (#22190) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createDispatchFnwhich allowed arbitrary method dispatch without a method allowlistTransportServerusage already validates viaschemaHasMethodDispatchMsgtype intocreate_dispatch_proxy.tswhere it's actually usedFixes A-745
🤖 Generated with Claude Code