Skip to content

fix: deflake HA governance voting test by polling for L1/DB convergence#22220

Merged
PhilWindle merged 1 commit into
merge-train/spartanfrom
sp/fix-ha-governance-vote-flake
Apr 1, 2026
Merged

fix: deflake HA governance voting test by polling for L1/DB convergence#22220
PhilWindle merged 1 commit into
merge-train/spartanfrom
sp/fix-ha-governance-vote-flake

Conversation

@spypsy

@spypsy spypsy commented Apr 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Fixes a race condition in the HA governance voting test where the DB records a duty as "signed" (crypto signing done) before the L1 transaction mines, causing l1VoteCount to be less than uniqueSlots.size
  • Merges the two-step approach (poll for votes > 0, then one-shot snapshot) into a single convergence loop that retries until L1 vote count matches DB duties

Fixes A-891

@PhilWindle PhilWindle merged commit 3d41528 into merge-train/spartan Apr 1, 2026
14 checks passed
@PhilWindle PhilWindle deleted the sp/fix-ha-governance-vote-flake branch April 1, 2026 16:13
github-merge-queue Bot pushed a commit that referenced this pull request Apr 6, 2026
BEGIN_COMMIT_OVERRIDE
fix: deflake HA governance voting test by polling for L1/DB convergence
(#22220)
feat(world-state): add genesis timestamp support and GenesisData type
(#22201)
chore: revert: feat(world-state): add genesis timestamp support and
GenesisData type (#22201) (#22255)
fix(archiver): handle duplicate checkpoint from L1 reorg (#22252)
chore: update dashboard (#22260)
fix: remove detailed revert codes (#22274)
chore: use ESO in grafana (#22271)
chore: (A-751) robust response error handling in json-rpc client
(#22246)
fix: separate fisherman StatefulSet from rpc-node and stop archiver
pollution (#22183)
fix: restore mainnet prover agents to 4 replicas (#22305)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants