fix: add account address to scopes in e2e_genesis_timestamp test#22238
Closed
AztecBot wants to merge 1 commit into
Closed
fix: add account address to scopes in e2e_genesis_timestamp test#22238AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
The test used NO_FROM without additionalScopes, resulting in empty scopes. Since PR #22136 removed ALL_SCOPES, empty scopes means no account keys are accessible during simulation. DeployAccountMethod.send() auto-injects the contract address via injectContractAddressIntoScopes, but proveInteraction bypasses that path. Adding accountManager.address to additionalScopes fixes the key validation error.
AztecBot
added
ci-draft
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure in
e2e_genesis_timestamp.test.tscaused by empty scopes when usingNO_FROM.Since PR #22136 removed
ALL_SCOPES, empty scopes means no account keys are accessible during simulation.DeployAccountMethod.send()auto-injects the contract address viainjectContractAddressIntoScopes, but the test usedproveInteractionwhich bypasses that path. AddingaccountManager.addresstoadditionalScopesfixes the key validation error.Test Plan
e2e_genesis_timestamp.test.tslocally — passes.ClaudeBox log: https://claudebox.work/s/21816c72fb89df72?run=1