fix: catch exceptions in ChonkBatchVerifier::batch_check#22273
Closed
AztecBot wants to merge 1 commit into
Closed
Conversation
…rrupted IPA proofs Corrupted IPA proofs can cause deserialization errors (e.g. 'Deserialized point is not on the curve') during batch_reduce_verify. Without a try/catch, this crashes the process. Now exceptions in batch_check are treated as batch failures, triggering bisection to isolate the bad proof(s).
AztecBot
added
ci-draft
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure in merge-train/barretenberg caused by PR #22266 (memory profiling switch).
The
ChonkBatchVerifierTests.RandomMixedBatchestest corruptsipa_proof[0]to create invalid proofs, which causes "Deserialized point is not on the curve" during IPA batch verification. Theparallel_reducephase already has try/catch for this, butbatch_check(which runs IPA verification) did not — causing an uncaught exception that aborted the process.The fix wraps the IPA batch verification in a try/catch, treating any exception as a batch failure so bisection can isolate the bad proof(s).
Test plan
chonk_tests— all 29 tests pass includingRandomMixedBatchesClaudeBox log: https://claudebox.work/s/9f588127e389c8cb?run=1