feat: merge-train/fairies#22456
Merged
Merged
Conversation
Robustly handles selection of return value when simulating private function by passing in the information of which call corresponds to the return value "user intends to get" from the wallet. I am not super sure this is the best way to go because it seems messy that we have that info bolted on `TxSimulationResult` when `TxSimulationResult` is more of a lower-level thing that doesn't care about what is a user call and what is a fee call. If we don't do it like that then this PR would need to become much bigger as we need to somehow forward that information. Happy to redo this if we come up with a better approach. Closes https://linear.app/aztec-labs/issue/F-483/handle-simulation-with-nested-calls-and-without-account-contract --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: thunkar <gregojquiros@gmail.com>
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: passing in user call info from wallet (#21937)
feat: add RPC endpoints to manipulate time (#22084)
END_COMMIT_OVERRIDE