fix: type-safe config parseEnv return types#22530
Merged
spalladino merged 1 commit intoApr 14, 2026
Merged
Conversation
AztecBot
added
ci-draft
spalladino
approved these changes
Apr 14, 2026
AztecBot
force-pushed
the
claudebox/fix-type-safe-config-ci
branch
from
158c9d2 to
df23f26
Compare
LHerskind
pushed a commit
that referenced
this pull request
Apr 15, 2026
## Summary Fixes two TypeScript type errors introduced by PR #22445 (refactor: type-safe config). `ConfigMappingsType<T>` uses `Required<T>[K]` to derive the `parseEnv` return type, so for optional `number` fields, `parseEnv` must return `number` — not `number | undefined`. The `undefined` case for missing env vars is already handled by the config framework before `parseEnv` is called. - `stdlib/src/config/sequencer-config.ts`: `attestationPropagationTime.parseEnv` now returns `number` instead of `number | undefined` - `p2p/src/config.ts`: `l1PublishingTime.parseEnv` now returns `number` instead of `number | undefined` ClaudeBox log: https://claudebox.work/s/1b406eba6bceb29c?run=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two TypeScript type errors introduced by PR #22445 (refactor: type-safe config).
ConfigMappingsType<T>usesRequired<T>[K]to derive theparseEnvreturn type, so for optionalnumberfields,parseEnvmust returnnumber— notnumber | undefined. Theundefinedcase for missing env vars is already handled by the config framework beforeparseEnvis called.stdlib/src/config/sequencer-config.ts:attestationPropagationTime.parseEnvnow returnsnumberinstead ofnumber | undefinedp2p/src/config.ts:l1PublishingTime.parseEnvnow returnsnumberinstead ofnumber | undefinedClaudeBox log: https://claudebox.work/s/1b406eba6bceb29c?run=1