feat(docs): apply FPC docs to developer versioned docs#22541
Merged
Conversation
ciaranightingale
requested changes
Apr 22, 2026
| 2. On L2, call `FeeJuice.claim(...)` to emit the Fee Juice nullifier. | ||
| 3. Call `PrivateFPC.mint(amount, salt, leaf_index)` to convert the bridge claim into private Fee Juice balance inside the FPC, credited to the claimer. | ||
| 4. From that point on, every transaction can call `PrivateFPC.pay_fee()` to deduct `max_gas_cost` from the internal balance and have the FPC set itself as the transaction's fee payer. | ||
| 2. **Cold-start:** First call `FeeJuice.claim(...)` so the Fee Juice nullifier lands onchain, then in a follow-up transaction call `PrivateFPC.mint_and_pay_fee(amount, salt, leaf_index)`. The contract verifies the nullifier exists, credits `amount - max_gas_cost` to the claimer, and pays the fee — useful when the user has no prior balance with the FPC. |
Contributor
There was a problem hiding this comment.
i don't really know what you mea by "cold start"
Contributor
There was a problem hiding this comment.
I don't get the second part at all? who is paying the initial fees? im lost sorry
critesjosh
requested review from
a team,
IlyasRidhuan,
LHerskind,
LeilaWang,
Maddiaa0,
charlielye,
dbanks12,
fcarreiro,
jeanmon,
just-mitch,
nventuro and
sirasistant
as code owners
Ports changes from #22496 (Nethermind FPC docs) and #22497 (private FPC guide) to the v4.2.0 developer versioned docs, plus related updates to source docs (docs-developers), transaction phases explanation, and runnable TypeScript examples. Files: - developer_versioned_docs/version-v4.2.0: how_to_pay_fees.md, how_to_use_private_fee_juice.md, foundational-topics/fees.md, foundational-topics/transactions.md - docs-developers: how_to_pay_fees.md, how_to_use_private_fee_juice.md, foundational-topics/fees.md, foundational-topics/transactions.md - examples/ts: aztecjs_advanced/index.ts, aztecjs_connection/index.ts
critesjosh
force-pushed
the
jc/docs-versioned-fpc-updates
branch
from
4f8f9d3 to
411124c
Compare
critesjosh
removed request for
a team,
IlyasRidhuan,
LHerskind,
LeilaWang,
Maddiaa0,
alejoamiras,
charlielye,
dbanks12,
fcarreiro,
just-mitch,
nventuro and
sirasistant
ciaranightingale
approved these changes
Apr 25, 2026
ciaranightingale
left a comment
ciaranightingale
left a comment
Contributor
There was a problem hiding this comment.
some m-dashes been added but otherwise lgtm
|
|
||
| ### Two flows | ||
|
|
||
| 1. **Bridge + mint + pay** (used the first time to seed a private balance, and then once per top-up): |
Contributor
There was a problem hiding this comment.
wdym once per top up?
Collaborator
|
❌ Failed to cherry-pick to |
3 tasks
critesjosh
added a commit
that referenced
this pull request
Apr 28, 2026
Backport of #22541 to `backport-to-v4-next-staging`. Cherry-picked merge commit `8b748b9c52` and resolved conflicts. The three-commit structure is preserved: cherry-pick with markers, conflict resolution, and one adaptation commit. Per-file analysis and resolution notes: https://gist.github.com/AztecBot/a68baa18840f313a136985d096d6be79 ## Path mapping The source PR modified `docs/developer_versioned_docs/version-v4.2.0/...`, but `version-v4.2.0/` does not exist in v4-next; the versioned docs there are split into `version-v4.1.0-rc.2` (testnet) and `version-v4.2.0-aztecnr-rc.2` (mainnet). Git's rename detection routed the changes: - Source `version-v4.2.0/foundational-topics/...` → `version-v4.1.0-rc.2/foundational-topics/...` - Source `version-v4.2.0/aztec-js/how_to_pay_fees.md` → `version-v4.2.0-aztecnr-rc.2/aztec-js/how_to_pay_fees.md` - Source `version-v4.2.0/aztec-js/how_to_use_private_fee_juice.md` (new file) → added under `version-v4.2.0-aztecnr-rc.2/aztec-js/` - Source `docs-developers/...` → same path I left the split as git produced it, matching the precedent in #22762. ## Reviewer notes - The split above is asymmetric (foundational-topics in `v4.1.0-rc.2`, aztec-js in `v4.2.0-aztecnr-rc.2`). Happy to propagate to both versioned trees for symmetric coverage. - `version-v4.2.0-aztecnr-rc.2/aztec-js/how_to_pay_fees.md` still contains older `Private FPCs enable…` / `Public FPCs can be used…` snippets that are now redundant with the new sections the PR introduced; left in place since the PR did not touch them. - `version-v4.1.0-rc.2/foundational-topics/fees.md` ended up with a duplicate `gas_settings.ts` source link (one v4.1.0-rc.2, one v4.2.0) from auto-merge; the duplicate is outside the conflict region so I did not touch it in the conflict-resolution commit. ## Test plan - [x] No conflict markers remain - [x] Code-block fences balanced in modified files - [ ] Docs build passes CI ClaudeBox log: https://claudebox.work/s/f04540a46c506217?run=1 ClaudeBox log: https://claudebox.work/s/f04540a46c506217?run=1
AztecBot
added a commit
that referenced
this pull request
Apr 29, 2026
BEGIN_COMMIT_OVERRIDE feat(docs): apply FPC docs to developer versioned docs (#22541) docs: apply FPC docs to versioned docs (backport #22541) (#22810) test(aztec-up): add full-dev-path e2e test for installed toolchain (#22801) fix: pass send message as (#22820) fix(aztec-up): handle CI=true in timeout function (#22827) refactor(sequencer): sign last block before archiver sync (#22117) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v4.2.0-aztecnr-rc.2developer versioned docshow_to_pay_fees.mdwith new payment methods table, deprecation notice, third-party FPC section (Nethermind example), and private fee payment sectionfees.md(foundational topics) with expanded FPC payment methods description, new "How FPCs work" section, and teardown phase clarificationhow_to_create_account.mdanchor links to match renamed headinghow_to_use_private_fee_juice.mdguide (DeFi Wonderland's PrivateFPC)Test plan
yarn startindocs/— verify versioned pages render correctly#sponsored-fpc-devnet-and-local-only,#third-party-fpcs-on-testnet-and-mainnet,#how-fpcs-work, and the new private FPC guide)