Skip to content

chore(avm)!: execution internal audit second pass#22552

Merged
jeanmon merged 18 commits into
merge-train/avmfrom
jean/avm-242-execution-second-pass
Apr 22, 2026
Merged

chore(avm)!: execution internal audit second pass#22552
jeanmon merged 18 commits into
merge-train/avmfrom
jean/avm-242-execution-second-pass

Conversation

@jeanmon

@jeanmon jeanmon commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Linear issue: AVM-242

@jeanmon jeanmon changed the base branch from next to merge-train/avm April 15, 2026 09:20
@jeanmon jeanmon marked this pull request as ready for review April 15, 2026 09:23
Comment thread barretenberg/cpp/pil/vm2/tx.pil Outdated
@jeanmon jeanmon force-pushed the jean/avm-242-execution-second-pass branch from 20f2fd2 to 56a8f35 Compare April 15, 2026 11:44
@jeanmon jeanmon requested review from MirandaWood and removed request for IlyasRidhuan and Maddiaa0 April 15, 2026 16:41

@MirandaWood MirandaWood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Thanks for the commit by commit changes! My comments are really just nits and doc suggestions. Only two things to really point out:

  • Approving assuming sel must always be 0 on the first row of execution
  • Query on sel_first_row_in_context at row 0

But can be addressed post merge if that's easier given the diff!

Comment thread barretenberg/cpp/src/barretenberg/vm2/tracegen/execution_trace.cpp Outdated
Comment thread barretenberg/cpp/src/barretenberg/vm2/tracegen/execution_trace.cpp
Comment thread barretenberg/cpp/src/barretenberg/vm2/constraining/relations/execution.test.cpp Outdated
Comment thread barretenberg/cpp/pil/vm2/context.pil Outdated
Comment thread barretenberg/cpp/pil/vm2/execution.pil
Comment thread barretenberg/cpp/pil/vm2/execution.pil Outdated
Comment thread barretenberg/cpp/pil/vm2/execution.pil
Comment thread barretenberg/cpp/pil/vm2/execution.pil Outdated
Comment thread barretenberg/cpp/pil/vm2/execution.pil
Comment thread barretenberg/cpp/src/barretenberg/vm2/tracegen/execution_trace.cpp
@jeanmon jeanmon force-pushed the jean/avm-242-execution-second-pass branch from 56a8f35 to 9bf9d81 Compare April 22, 2026 12:32
@jeanmon jeanmon merged commit c91c347 into merge-train/avm Apr 22, 2026
12 checks passed
@jeanmon jeanmon deleted the jean/avm-242-execution-second-pass branch April 22, 2026 13:50
@AztecBot AztecBot mentioned this pull request Apr 22, 2026
chrismarino pushed a commit to chrismarino/aztec-packages that referenced this pull request May 5, 2026
BEGIN_COMMIT_OVERRIDE
chore(avm)!: execution internal audit second pass (AztecProtocol#22552)
test(avm): integration test for alu truncation (AztecProtocol#22684)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants