Skip to content

feat: offchain delivered private transfer#22574

Merged
mverzilli merged 20 commits into
merge-train/fairiesfrom
martin/token-transfer-in-private-deliver-offchain
Apr 23, 2026
Merged

feat: offchain delivered private transfer#22574
mverzilli merged 20 commits into
merge-train/fairiesfrom
martin/token-transfer-in-private-deliver-offchain

Conversation

@mverzilli

@mverzilli mverzilli commented Apr 15, 2026

Copy link
Copy Markdown
Contributor
  • Adds a transfer_in_private_deliver_offchain to the Token contract.
  • Extends TXE to facilitate Noir tests involving offchain messages.

Some contorsions were necessary to make offchain_receive available as a regular utility callable from Noir. To my surprise this is the first case of an aztec-macro-generated utility we try to make available that way. Happy to hear if there are better/less ad-hoc ways to do so.

@mverzilli mverzilli marked this pull request as ready for review April 16, 2026 15:12
@mverzilli mverzilli requested a review from nventuro as a code owner April 16, 2026 15:12
@mverzilli mverzilli requested review from benesjan and nchamo April 16, 2026 15:12

@benesjan benesjan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't yet manage to finish full review but sending what I got so far as I am not sure if I'll manage to finish it today

Comment thread noir-projects/aztec-nr/aztec/src/test/helpers/test_environment.nr Outdated
Comment thread noir-projects/aztec-nr/aztec/src/test/helpers/test_environment.nr Outdated
Comment thread noir-projects/aztec-nr/aztec/src/test/helpers/test_environment.nr Outdated

@nchamo nchamo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to finally see this on the token contract ❤️

I have a few questions I need your help with

Comment thread noir-projects/noir-contracts/contracts/app/token_contract/src/main.nr Outdated
Comment thread yarn-project/txe/src/rpc_translator.ts Outdated
Comment thread yarn-project/txe/src/rpc_translator.ts Outdated
Comment thread noir-projects/aztec-nr/aztec/src/test/helpers/txe_oracles.nr Outdated
Comment thread noir-projects/aztec-nr/aztec/src/test/helpers/test_environment.nr Outdated
Comment thread yarn-project/txe/src/txe_session.ts
@mverzilli mverzilli requested a review from nchamo April 22, 2026 09:13

@nchamo nchamo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Comment thread yarn-project/txe/src/txe_session.ts
Comment thread yarn-project/txe/src/txe_session.ts
Comment thread noir-projects/aztec-nr/aztec/src/macros/calls_generation/external_functions.nr Outdated
Comment thread yarn-project/txe/src/rpc_translator.ts Outdated
Comment thread yarn-project/txe/src/rpc_translator.ts
@mverzilli mverzilli added the ci-full Run all master checks. label Apr 23, 2026
@mverzilli mverzilli merged commit c688d6f into merge-train/fairies Apr 23, 2026
26 checks passed
@mverzilli mverzilli deleted the martin/token-transfer-in-private-deliver-offchain branch April 23, 2026 13:29
AztecBot pushed a commit that referenced this pull request Apr 23, 2026
- Adds a `transfer_in_private_deliver_offchain` to the `Token` contract.
- Extends TXE to facilitate Noir tests involving offchain messages.

Some contorsions were necessary to make `offchain_receive` available as
a regular utility callable from Noir. To my surprise this is the first
case of an aztec-macro-generated utility we try to make available that
way. Happy to hear if there are better/less ad-hoc ways to do so.

---------

Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
@AztecBot

Copy link
Copy Markdown
Collaborator

✅ Successfully backported to backport-to-v4-next-staging #22742.

AztecBot added a commit that referenced this pull request Apr 23, 2026
BEGIN_COMMIT_OVERRIDE
feat: offchain delivered private transfer (#22574)
END_COMMIT_OVERRIDE
chrismarino pushed a commit to chrismarino/aztec-packages that referenced this pull request May 5, 2026
BEGIN_COMMIT_OVERRIDE
feat: offchain delivered private transfer (AztecProtocol#22574)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v4-next ci-full Run all master checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants