Skip to content

refactor(pxe): rename sideEffectCounter to initialSideEffectCounter #22599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nchamo merged 1 commit into from
Apr 17, 2026
Merged

refactor(pxe): rename sideEffectCounter to initialSideEffectCounter #22599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions yarn-project/pxe/src/contract_function_simulator/oracle/private_execution_oracle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export class PrivateExecutionOracle extends UtilityExecutionOracle implements IP
private readonly taggingIndexCache: ExecutionTaggingIndexCache;
private readonly senderTaggingStore: SenderTaggingStore;
private totalPublicCalldataCount: number;
protected sideEffectCounter: number;
private readonly initialSideEffectCounter: number;
private senderForTags?: AztecAddress;
private readonly simulator?: CircuitSimulator;

Expand All @@ -100,13 +100,18 @@ export class PrivateExecutionOracle extends UtilityExecutionOracle implements IP
this.taggingIndexCache = args.taggingIndexCache;
this.senderTaggingStore = args.senderTaggingStore;
this.totalPublicCalldataCount = args.totalPublicCalldataCount ?? 0;
this.sideEffectCounter = args.sideEffectCounter ?? 0;
this.initialSideEffectCounter = args.sideEffectCounter ?? 0;
this.senderForTags = args.senderForTags;
this.simulator = args.simulator;
}

public getPrivateContextInputs(): PrivateContextInputs {
return new PrivateContextInputs(this.callContext, this.anchorBlockHeader, this.txContext, this.sideEffectCounter);
return new PrivateContextInputs(
this.callContext,
this.anchorBlockHeader,
this.txContext,
this.initialSideEffectCounter,
);
}

// We still need this function until we can get user-defined ordering of structs for fn arguments
Expand Down
Loading