chore: update databus relation to remove need for read tags#22610
Merged
ledwards2225 merged 11 commits intoApr 17, 2026
Conversation
ledwards2225
commented
Apr 16, 2026
| * @tparam AllValues | ||
| * @param row | ||
| */ | ||
| template <size_t bus_idx, typename AllValues> static bool operation_exists_at_row(const AllValues& row) |
Contributor
Author
There was a problem hiding this comment.
this was already unused
federicobarbacovi
approved these changes
Apr 17, 2026
federicobarbacovi
left a comment
federicobarbacovi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for doing this!
ledwards2225
merged commit 1b0dc31
into
merge-train/barretenberg
16 of 18 checks passed
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 18, 2026
BEGIN_COMMIT_OVERRIDE chore: update databus relation to remove need for read tags (#22610) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the Databus relation to avoid the need for
read_tags(boolean witnesses indicatingread_counts> 0)Previously the databus relation had the following inverse correctness subrelation:
(lookup_term * table_term * inverses - inverse_exists) * scaling_factorwhere
inverse_exists = is_read + read_tag - is_read * read_tagThis PR splits this into two subrelations, one for reads and one for writes:
(1a):
(lookup_term * table_term * inverses - 1) * is_read(1b):
(lookup_term * table_term * inverses - 1) * countThe lookup subrelation itself remains unchanged. This keeps the total number of subrelations at three but removes one witness poly per databus column.