Skip to content

fix(aztec): fail fast when nc is not installed in aztec test#22692

Merged
nchamo merged 2 commits into
merge-train/fairiesfrom
fix/nc-check-aztec-test
Apr 21, 2026
Merged

fix(aztec): fail fast when nc is not installed in aztec test#22692
nchamo merged 2 commits into
merge-train/fairiesfrom
fix/nc-check-aztec-test

Conversation

@nchamo

@nchamo nchamo commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Problem

aztec test uses nc -z to poll for TXE server readiness, but redirects all output to /dev/null. When nc is not installed, the "command not found" error is swallowed, the loop treats it as "server not ready yet", and sleeps forever with no output.

Both macOS and most Linux distributions ship with nc pre-installed, but some bare Docker images (e.g. ubuntu:24.04) do not, which is where this surfaces.

Fix

Adds a command -v nc check before the polling loop, failing immediately with a clear error message if netcat is missing.

Fixes F-571

@nchamo nchamo self-assigned this Apr 21, 2026
@nchamo nchamo requested a review from mverzilli April 21, 2026 11:57
@nchamo nchamo merged commit 8931ac2 into merge-train/fairies Apr 21, 2026
11 checks passed
@nchamo nchamo deleted the fix/nc-check-aztec-test branch April 21, 2026 12:55
dipkakwani pushed a commit to dipkakwani/aztec-packages that referenced this pull request Apr 22, 2026
BEGIN_COMMIT_OVERRIDE
fix(aztec): fail fast when nc is not installed in aztec test (AztecProtocol#22692)
docs: link to apiref, not gh, remove stale include code markers (AztecProtocol#22649)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants