chore: Fix translator's static assert#22695
Merged
federicobarbacovi merged 2 commits intoApr 21, 2026
Merged
Conversation
suyash67
reviewed
Apr 21, 2026
|
|
||
| // The number of masking values in the overflow columns used for the ordered range constraint | ||
| static constexpr size_t MASKING_OVERFLOW_COLUMN = | ||
| MAX_RANDOM_VALUES_PER_ORDERED * (NUM_CONCATENATED_POLYS - 1) / NUM_CONCATENATED_POLYS; |
Contributor
There was a problem hiding this comment.
I think we should use NUM_ORDERED_RANGE here instead of NUM_CONCATENATED_POLYS because although both are currently equal (to 5), NUM_CONCATENATED_POLYS could change in future.
We calculate NUM_CONCATENATED_POLYS as
suyash67
approved these changes
Apr 21, 2026
suyash67
left a comment
suyash67
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for fixing this!
dipkakwani
pushed a commit
to dipkakwani/aztec-packages
that referenced
this pull request
Apr 22, 2026
BEGIN_COMMIT_OVERRIDE chore!: masking at the top of the trace (AztecProtocol#22334) chore: Fix translator's static assert (AztecProtocol#22695) chore: bump mem for large circuit test (AztecProtocol#22690) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the static assert in Translator: the size for the translator is determined by the
MINI_CIRCUIT_SIZE * CONCATENATION_GROUP_SIZE. This number must be bigger thanSORTED_STEPS(which is the max size of the microlimbs divided by 3) timesNUM_ORDERED_RANGE(1 + the number of interleaved polynomials) plus the masking rows in the overflow column (which are equal to4 * 64 / 5(see the README).The old static assert compared
SORTED_STEPStimes1 + NUM_CONCATENATED_POLYSwith the size of the translator.