fix(e2e): wait for checkpoint in fee_asset_price_oracle_gossip test#22700
Closed
AztecBot wants to merge 1 commit into
Closed
fix(e2e): wait for checkpoint in fee_asset_price_oracle_gossip test#22700AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
c342802 to
74894c2
Compare
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the merge-train/spartan CI failure from
Merge branch 'next' into merge-train/spartan(504c330) — thefee_asset_price_oracle_gossiptest threwTypeError: Cannot read properties of undefined (reading 'checkpoint')atfee_asset_price_oracle_gossip.test.ts:175.CI run: https://github.com/AztecProtocol/aztec-packages/actions/runs/24730852209
Failing test log: http://ci.aztec-labs.com/0e05c9015c65aae1
Root cause
The merge brought in #22535 (skip initial sequencer in p2p/epochs tests), which stopped
applyBaseSetupfrom mining an initial block and madesetupAccounta PXE-only register (no on-chain tx). Sibling testsgossip_network.test.tsandgossip_network_no_cheat.test.tswere migrated at the same time to submit txs and resolve the checkpoint viagetCheckpointedBlock(blockNumber).checkpointNumber, but this spartan-only test was missed and still ran:With no block built yet,
blockNumberis 0 andgetCheckpointsreturns[], so the destructuredpublishedCheckpointisundefined.Fix
Replace the racy one-shot lookup with a
retryUntilthat waits for (1) a block to be built, (2) that block to be checkpointed, and (3) its checkpoint to be present in the archiver with attestations. Drop the now-unusedCheckpointNumberimport.Verification
Ran the single test locally after
make yarn-project:Full local
./bootstrap.sh ciwas not feasible in the claudebox container (thespartantarget needshelm/terraform, neither of which is available locally). Full details: https://gist.github.com/AztecBot/25382b8be3dd7a5a15c90f1c2587a983Test plan
merge-train/spartanpasses for the fee_asset_price_oracle_gossip testClaudeBox log: https://claudebox.work/s/495875797419bb4d?run=1