fix(docs): retry flaky solc download in compile-solidity, fail-fast on persistent error#22903
Closed
AztecBot wants to merge 1 commit into
Closed
fix(docs): retry flaky solc download in compile-solidity, fail-fast on persistent error#22903AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
…n persistent error
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
merge-train/barretenberg(PR #22893, run https://github.com/AztecProtocol/aztec-packages/actions/runs/25226353436) failed becausebinaries.soliditylang.orgDNS lookup intermittently failed whileforge buildwas downloading solc 0.8.27 for the first solidity subdir (aave_bridge). Thecompile-solidityloop indocs/examples/bootstrap.shthen silently swallowed the failure (it runs underset +e), continued with the next subdirs (which now had solc cached and succeeded), and reported success. The TypeScript validation step then blew up on missingaave_bridge/AavePortal.sol/AavePortal.jsonetc., taking down the docs job.This is unrelated to the actual change in #22893 (which only touches barretenberg C++).
Fix
In
docs/examples/bootstrap.sh::compile-solidity:forge buildup to 3 times with 5s backoff to absorb transient solc-download failures.exit 1from the subshell and propagate up via|| return 1sorun_step's outer retry kicks in (and, if that also fails, the Slack notifier and the build correctly fail).Test plan
docs/target/solidityand ran./docs/examples/bootstrap.sh compile-soliditylocally; all three subdirs compile and the fouraave_bridgeJSON files referenced fromdocs/examples/ts/aave_bridge/index.tsare produced.Detailed analysis: https://gist.github.com/AztecBot/cab76a55438b3c9dc156829e8209197f
ClaudeBox log: https://claudebox.work/s/ea65e649c8b4b51f?run=1