Skip to content

chore: notify slack users directly#22944

Merged
alexghr merged 1 commit into
merge-train/spartanfrom
ag/grafana-slack-mentions
May 5, 2026
Merged

chore: notify slack users directly#22944
alexghr merged 1 commit into
merge-train/spartanfrom
ag/grafana-slack-mentions

Conversation

@alexghr

@alexghr alexghr commented May 5, 2026

Copy link
Copy Markdown
Contributor

Notify slack users directly in Grafan alerts

@alexghr alexghr requested a review from charlielye as a code owner May 5, 2026 11:28
@alexghr alexghr added the ci-skip label May 5, 2026
type: slack
settings:
url: $SLACK_WEBHOOK_URL
mentionUsers: $SLACK_ALERT_MENTION_USER_IDS

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how escapes work here, but given this is a comma separated list, do we need to quote it or anything?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ought to be interpreted as a yaml array

variable "SLACK_ALERT_MENTION_USER_IDS" {
description = "Optional Slack user IDs to mention on Grafana alert notifications."
type = list(string)
default = ["U0AHB6VR8N5"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand claudebox is an app, not a user. Do mentions work the same?

@alexghr alexghr merged commit a9c6ad7 into merge-train/spartan May 5, 2026
20 of 24 checks passed
@alexghr alexghr deleted the ag/grafana-slack-mentions branch May 5, 2026 12:46
danielntmd pushed a commit to danielntmd/aztec-packages that referenced this pull request May 6, 2026
BEGIN_COMMIT_OVERRIDE
refactor(archiver)!: simplify L2BlockSource block lookups (AztecProtocol#22809)
chore(lint): allow branded primitive types as keys in collections
(AztecProtocol#22935)
test(e2e): test missed l1 publishing under pipelining (AztecProtocol#22926)
fix: dedup attestation pool by payload hash (AztecProtocol#22871)
chore: notify slack users directly (AztecProtocol#22944)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants