test: share e2e code with canary#2299
Merged
Merged
Conversation
…ec-packages into spy/canary-common-code
spypsy
commented
Sep 15, 2023
| echo "Updating external Aztec dependencies to version $VERSION" | ||
|
|
||
| # Packages that are publically available in npm | ||
| TARGET_PKGS=("@aztec/aztec.js" "@aztec/cli" "@aztec/l1-artifacts" "@aztec/noir-contracts") |
Member
Author
There was a problem hiding this comment.
Thought of a better way to do this, grabbing the dependencies from the canary package rather than manually maintaining the list here, updating now
benesjan
approved these changes
Sep 15, 2023
benesjan
left a comment
benesjan
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Having the test suites in e2e makes sense. Just a minor comment.
| const privKey = AztecJs.GrumpkinScalar.random(); | ||
|
|
||
| /** | ||
| * This test is a bit of a special case as it's relying on sandbox and web browser and not only on anvil and node.js. |
Contributor
There was a problem hiding this comment.
I think it would make more sense to have this comment in the test files and not in the test suite files given that we don't execute this file directly.
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
PhilWindle
reviewed
Sep 18, 2023
| ENV CHROME_BIN="/usr/bin/chromium-browser" PUPPETEER_SKIP_CHROMIUM_DOWNLOAD="true" | ||
|
|
||
| ARG COMMIT_TAG="" | ||
| ARG COMMIT_TAG="0.7.5" |
Collaborator
There was a problem hiding this comment.
@spypsy Should this have a default value? Or should it have an invalid default value so we catch the case where COMMIT_TAG isn't being provided?
Member
Author
There was a problem hiding this comment.
You're right, it's better to hardcode an invalid tag so it fails with a logged error.
Fixed here: https://github.com/AztecProtocol/aztec-packages/pull/2371/files
spypsy
pushed a commit
that referenced
this pull request
Sep 18, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.7.6</summary> ## [0.7.6](aztec-packages-v0.7.5...aztec-packages-v0.7.6) (2023-09-18) ### Features * New api to get note nonces ([#2327](#2327)) ([8f5eb28](8f5eb28)) * Replace private token in testing ([#2304](#2304)) ([934ba96](934ba96)) ### Bug Fixes * Exit with error log when COMMIT_TAG is not set properly on canary ([#2371](#2371)) ([68fe053](68fe053)) * Preserve public function call ordering in account entrypoint ([#2348](#2348)) ([5b2cf75](5b2cf75)) * Return output-debug flag ([#2364](#2364)) ([af86580](af86580)) * Revert "fix: strip leading 'v' from dockerhub tags" ([#2367](#2367)) ([53bc041](53bc041)) * Stale CLI docs ([#2336](#2336)) ([f38873b](f38873b)) * Strip leading 'v' from dockerhub tags ([#2360](#2360)) ([a4bb05c](a4bb05c)) ### Miscellaneous * Added docs for artifact files ([#2362](#2362)) ([6d3ba3f](6d3ba3f)), closes [#2190](#2190) * **aztec_noir:** Remove inputs from consume l1 to l2 message ([#2354](#2354)) ([2235f7c](2235f7c)) * Remove "as unknown" casts for ABIs where possible ([#2331](#2331)) ([bf2651e](bf2651e)) * Script to extract tag version ([#2368](#2368)) ([4b686b0](4b686b0)) * Share e2e code with canary ([#2299](#2299)) ([21224de](21224de)) </details> <details><summary>barretenberg.js: 0.7.6</summary> ## [0.7.6](barretenberg.js-v0.7.5...barretenberg.js-v0.7.6) (2023-09-18) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.7.6</summary> ## [0.7.6](barretenberg-v0.7.5...barretenberg-v0.7.6) (2023-09-18) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2054
Refactoring so that CLI & Browser e2e tests share code from
end-to-endChecklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.