Skip to content

feat: extend databus with 2 more cols#23010

Merged
federicobarbacovi merged 7 commits into
merge-train/barretenbergfrom
lde/two-more-db
May 7, 2026
Merged

feat: extend databus with 2 more cols#23010
federicobarbacovi merged 7 commits into
merge-train/barretenbergfrom
lde/two-more-db

Conversation

@ledwards2225

@ledwards2225 ledwards2225 commented May 6, 2026

Copy link
Copy Markdown
Contributor

Extend the databus columns to support return data for up to three apps.

@ledwards2225 ledwards2225 marked this pull request as ready for review May 6, 2026 20:17
@ledwards2225 ledwards2225 requested a review from LeilaWang as a code owner May 6, 2026 20:17
@ledwards2225 ledwards2225 added the ci-full Run all master checks. label May 6, 2026
inline constexpr size_t HIDING_KERNEL_GATE_COUNT = 78356;
inline constexpr size_t HIDING_KERNEL_ECC_ROWS = 5301 + MSM_ROWS_OFFSET;
inline constexpr size_t HIDING_KERNEL_ULTRA_OPS = 356;
inline constexpr size_t HIDING_KERNEL_GATE_COUNT = 76871;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flag: why does this decrease?

using BuilderType = typename BuilderTypeHelper<Curve>::type;

static constexpr size_t VERIFIER_NUM_GATES = NumSubtables == 9 ? 10456 : 47322;
static constexpr size_t VERIFIER_NUM_GATES = NumSubtables == 9 ? 10456 : 44426;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess bc this decreases but why does this decrease..

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This decreases because the number of max circuits in Chonk goes down, so the batch merge verifier needs to perform fewer operations (both in terms of hashing and in terms of ecc ops)

@federicobarbacovi federicobarbacovi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this!

@federicobarbacovi federicobarbacovi enabled auto-merge (squash) May 7, 2026 13:36
@federicobarbacovi federicobarbacovi merged commit f21b7df into merge-train/barretenberg May 7, 2026
14 checks passed
@federicobarbacovi federicobarbacovi deleted the lde/two-more-db branch May 7, 2026 15:26
rangozd pushed a commit to rangozd/aztec-packages that referenced this pull request May 16, 2026
BEGIN_COMMIT_OVERRIDE
fix(bb): clamp BatchMergeProver degree-check loop to fix nightly debug
SIGABRT (AztecProtocol#23019)
feat: extend databus with 2 more cols (AztecProtocol#23010)
feat: n1 apps (AztecProtocol#22974)
chore: remove chonk bench once and for all (AztecProtocol#23067)
fix(bb): clamp BatchMergeProver degree-check loop to fix nightly debug
SIGABRT (AztecProtocol#23077)
feat!: optimized Poseidon2  (AztecProtocol#22652)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-full Run all master checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants