fix(bb): regen Prover.toml fixtures and forge-fmt Debug.sol#23017
Closed
AztecBot wants to merge 1 commit into
Closed
fix(bb): regen Prover.toml fixtures and forge-fmt Debug.sol#23017AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix CI failure on
merge-train/barretenberg(run 25476931781, log http://ci.aztec-labs.com/1778128976063647).nargo execute --program-dir noir-projects/noir-protocol-circuits/crates/private-kernel-initfailed with:The committed
Prover.tomlfixtures embed serialized VKs / proofs whose length is sensitive to recent barretenberg constant changes on this train (notablyHIDING_KERNEL_LOG_N16→17, newMAX_APPS_PER_KERNEL/CHONK_MAX_NUM_CIRCUITS/BATCH_MERGE_PROOF_SIZE). This is the exact failure mode documented inbarretenberg/cpp/CLAUDE.md(Prover.toml Fixtures, added in #23014).Changes
Prover.tomlfixtures via:forge fmtbarretenberg/sol/test/utils/Debug.sol— the file was reformatted mid-build bybarretenberg/sol/bootstrap.shbuild_sol(forge fmt || true), which raised[bb-sol-tests] ERROR: Noticed changes to rebuild patterns during CI run: barretenberg/sol/test/utils/Debug.solwarnings and perturbed downstream cache hashes. Pre-formatting at rest eliminates the drift.Verification
nargo executeon all 18 affected crates locally:Circuit witness successfully solved✅ (12 regenerated + the 6 not-covered-by-full.testcrates that turned out to still be valid, so theorchestrator_single_checkpointregen step was not needed).Detailed analysis: https://gist.github.com/AztecBot/293ccaae4f9337c64e4c5a5c4f44bee3
ClaudeBox log: https://claudebox.work/s/b956259ee219c45e?run=1