Skip to content

port(v4-next): feat(ci): Snapshots for aztec-nr contract compilation failures and nargo expand (#23061)#23104

Merged
vezenovm merged 3 commits into
backport-to-v4-next-stagingfrom
claudebox/backport-23061-v4-next
May 8, 2026
Merged

port(v4-next): feat(ci): Snapshots for aztec-nr contract compilation failures and nargo expand (#23061)#23104
vezenovm merged 3 commits into
backport-to-v4-next-stagingfrom
claudebox/backport-23061-v4-next

Conversation

@AztecBot

@AztecBot AztecBot commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Backport of #23061 to v4-next.

Conflicts

The automatic cherry-pick failed with 3 rename/delete conflicts (no text markers):

Commits

  1. feat(ci): cherry-pick #23061 (with conflicts) — raw cherry-pick result with the two stray files (bootstrap.sh, expected_error) preserved as-is so reviewers can see what conflicted.
  2. fix: resolve cherry-pick conflicts — removes those two stray files in line with feat(ci): Snapshots for aztec-nr contract compilation failures and nargo expand #23061's intent (the whole old crate is dropped).

Verification

cargo build --tests, cargo fmt --check, and cargo clippy --all-targets all pass for the new noir-projects/contract-snapshots/ crate. The compile_failure snapshots and nargo expand outputs are exercised against the live Noir compiler in CI; any drift will surface there.

ClaudeBox log: https://claudebox.work/s/9ae41fb6fbae7191?run=2

vezenovm and others added 2 commits May 8, 2026 17:25
Cherry-picks f3911a8 feat(ci): Snapshots for aztec-nr contract
compilation failures and nargo expand (#23061).

Conflicts (rename/delete style — no text markers):
- noir-projects/contract-snapshots/test_programs/compile_failure/invalid_event/src/invalid_event.nr
  (renamed by #23061, deleted in v4-next-staging) — kept the renamed copy.
- noir-projects/noir-contracts-comp-failures/bootstrap.sh and
  noir-projects/noir-contracts-comp-failures/contracts/authorization_selector_collision/expected_error
  (deleted by #23061, modified in v4-next-staging) — left as-is in this
  commit (HEAD content), removed in the follow-up resolution commit so
  reviewers can see what conflicted.
Removes the two stray files (bootstrap.sh and authorization_selector_collision/expected_error)
that #23061 deleted as part of dropping the noir-contracts-comp-failures
crate. Both had been modified on v4-next-staging, which created the
rename/delete conflicts; the entire old crate is gone in #23061's
direction.
@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels May 8, 2026
@socket-security

socket-security Bot commented May 8, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcargo/​insta@​1.47.29310093100100

View full report

@vezenovm vezenovm marked this pull request as ready for review May 8, 2026 17:33
@vezenovm vezenovm enabled auto-merge May 8, 2026 17:33
Re-runs the cargo-insta snapshot tests against the v4-next compiler and
the v4-next aztec-nr / contract code, accepting the diffs:

- compile_failure/authorization_selector_collision: one extra
  'check_parent_traits_are_implemented: missing trait ID' diagnostic on
  v4-next's authorization.nr.
- expand/avm_gadgets_test_contract: keccak_hash_300 doesn't exist on
  v4-next's avm_gadgets_test_contract.
- expand/avm_test_contract: ordering / minor signature differences on
  v4-next's avm_test_contract.
@vezenovm vezenovm merged commit c5bc4f1 into backport-to-v4-next-staging May 8, 2026
11 checks passed
@vezenovm vezenovm deleted the claudebox/backport-23061-v4-next branch May 8, 2026 18:15
AztecBot added a commit that referenced this pull request May 9, 2026
BEGIN_COMMIT_OVERRIDE
fix(aztec-up): Aztec installer does not shadow user installed binaries
on PATH (#22902)
fix: include sqlite binary in its npm package (#23039)
chore: backport #23041 (add sendMessagesAs to wallet api schemas) to
v4-next (#23081)
chore: backport DeployMethod refactor (#22985) to v4-next (#23029)
refactor(pxe): deduplicate tx hash lookups in MessageContextService
(#23075)
refactor(pxe): batch tagged private log queries across all secrets
(#23048)
refactor(pxe): batch log RPC calls in LogService.fetchLogsByTag (#23088)
feat(aztec-nr): Initial handshake registry contract with non interactive
handshake function (#22854)
fix: add Tag.random() helper required by backported #23088 tests
(#23094)
chore: backport: fix(aztec-up): installer does not shadow user binaries
on PATH (#22902) (#23060)
chore: backport handshake registry contract (#22854) to v4-next (#23063)
feat: deploy method refactor 2 (#23033)
refactor(pxe): skip redundant getBlock RPC when querying at anchor block
(#23100)
port(v4-next): feat(docs): autogenerate node JSON-RPC API reference
(#22543) (#23046)
chore: backport feat: deploy method refactor 2 (#23033) to v4-next
(#23103)
port(v4-next): feat(ci): Snapshots for aztec-nr contract compilation
failures and nargo expand (#23061) (#23104)
feat(txe): allow authorizing cross-contract utility calls in nr tests
(#23064)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants