-
Notifications
You must be signed in to change notification settings - Fork 611
feat(ci): run aztec-cli acceptance test on macOS #23309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vezenovm
merged 2 commits into
merge-train/fairies
from
nchamo/f-566-explore-macos-ci-coverage-for-the-full-dev-onboarding-path
May 19, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,8 @@ | |
| # Launcher for the Aztec CLI acceptance test. | ||
| # | ||
| # Steps: | ||
| # 1. Install Node via NVM if not present (skipped with SKIP_INSTALL=1) | ||
| # 1. Install NVM and the latest LTS Node (skipped with SKIP_INSTALL=1). NVM is required by the | ||
| # aztec installer to upgrade Node when the system version is too old. | ||
| # 2. Install the Aztec toolchain via the public installer (skipped with SKIP_INSTALL=1) | ||
| # 3. Run aztec-cli-acceptance-test.ts which exercises the installed toolchain end-to-end | ||
| # | ||
|
|
@@ -20,14 +21,17 @@ else | |
| echo "ERROR: VERSION must be set when SKIP_INSTALL is not 1." >&2 | ||
| exit 1 | ||
| fi | ||
| if ! command -v node &>/dev/null; then | ||
| echo ">>> Installing Node via NVM" | ||
| if [ ! -f "$HOME/.nvm/nvm.sh" ]; then | ||
| echo ">>> Installing NVM" | ||
| curl -sL https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.3/install.sh -o /tmp/nvm-install.sh | ||
| PROFILE=/dev/null bash /tmp/nvm-install.sh | ||
| export NVM_DIR="$HOME/.nvm" | ||
| set +eu; . "$NVM_DIR/nvm.sh"; set -eu | ||
| nvm install --lts | ||
| fi | ||
|
|
||
| # Install latest LTS node, since we need it to run the acceptance test correctly | ||
| export NVM_DIR="$HOME/.nvm" | ||
| set +eu; . "$NVM_DIR/nvm.sh"; set -eu | ||
| echo ">>> Installing latest LTS Node via NVM" | ||
| nvm install --lts | ||
| echo ">>> Installing aztec ${VERSION}" | ||
|
Comment on lines
+30
to
35
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We always install LTS node, so we can make sure we can run the test properly |
||
| NO_NEW_SHELL=1 VERSION="${VERSION}" bash <(curl -sL https://install.aztec.network) | ||
| fi | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are now handling this in
run-test.sh