fix(aztec-nr): update aes128 test mock for renamed batched shared_secrets oracle#23380
Closed
AztecBot wants to merge 1 commit into
Closed
fix(aztec-nr): update aes128 test mock for renamed batched shared_secrets oracle#23380AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #23352 (
feat!: make get_shared_secrets batched oracle call) renamed the shared-secret oracle fromaztec_utl_getSharedSecret(singular) to a batchedaztec_utl_getSharedSecrets(plural) that returns a slot to anEphemeralArray<Field>of results. All production call sites were updated, but one stale mock inaes128.nrwas missed, which broke themessages::encryption::aes128::test::encrypt_decrypt_deterministictest onmerge-train/fairiesCI.Failure
No public key registered for address 0x25af…be70c.Because the test mocked the now-defunct oracle name, the realaztec_utl_getSharedSecretsoracle ran against the hard-coded recipient address, which is not registered as an account.Fix
Update the test mock to match the new batched oracle's contract: push
s_appinto anEphemeralArray<Field>at a slot, then mockaztec_utl_getSharedSecretsto return that slot. This mirrors themock_get_shared_secretshelper inoracle/shared_secret.nradded in #23352.Full analysis: https://gist.github.com/AztecBot/da9da98fa2a3f10c8ff01fbaafa76995
ClaudeBox log: https://claudebox.work/s/827cef6e916dd72c?run=1