Skip to content

fix(aztec-nr): update aes128 test mock for renamed batched shared_secrets oracle#23380

Closed
AztecBot wants to merge 1 commit into
merge-train/fairiesfrom
claudebox/fix-fairies-shared-secrets
Closed

fix(aztec-nr): update aes128 test mock for renamed batched shared_secrets oracle#23380
AztecBot wants to merge 1 commit into
merge-train/fairiesfrom
claudebox/fix-fairies-shared-secrets

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Summary

PR #23352 (feat!: make get_shared_secrets batched oracle call) renamed the shared-secret oracle from aztec_utl_getSharedSecret (singular) to a batched aztec_utl_getSharedSecrets (plural) that returns a slot to an EphemeralArray<Field> of results. All production call sites were updated, but one stale mock in aes128.nr was missed, which broke the messages::encryption::aes128::test::encrypt_decrypt_deterministic test on merge-train/fairies CI.

Failure

Fix

Update the test mock to match the new batched oracle's contract: push s_app into an EphemeralArray<Field> at a slot, then mock aztec_utl_getSharedSecrets to return that slot. This mirrors the mock_get_shared_secrets helper in oracle/shared_secret.nr added in #23352.

Full analysis: https://gist.github.com/AztecBot/da9da98fa2a3f10c8ff01fbaafa76995

ClaudeBox log: https://claudebox.work/s/827cef6e916dd72c?run=1

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels May 18, 2026
@AztecBot

Copy link
Copy Markdown
Collaborator Author

Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed.

@AztecBot AztecBot closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant