Skip to content

fix: avoid npm uplink for aztec-up local publishes#23396

Merged
alexghr merged 2 commits into
merge-train/spartanfrom
ag/fix-aztec-up-local-npm-publish
May 19, 2026
Merged

fix: avoid npm uplink for aztec-up local publishes#23396
alexghr merged 2 commits into
merge-train/spartanfrom
ag/fix-aztec-up-local-npm-publish

Conversation

@alexghr

@alexghr alexghr commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Keep @aztec/* local in the aztec-up Verdaccio build registry so publishing Aztec packages does not depend on npmjs uplink health.
  • Continue proxying other scoped and unscoped packages to npmjs for dependency cache priming.

CI failure investigated:

  • PR feat: merge-train/spartan #23344 failed ./bootstrap.sh, ci/x-full-no-test-cache, and npm publish contexts.
  • Downloaded logs with yarn ci dlog: f5535395aab63996, 1779189592567743, and 51444ba79e6c8a4a.
  • The direct npm publish log failed with E503: one of the uplinks is down, refuse to publish, while publishing @aztec/protocol-contracts to local Verdaccio.

Validation:

  • bash -n aztec-up/bootstrap.sh

@alexghr alexghr requested a review from charlielye as a code owner May 19, 2026 13:02
@alexghr alexghr enabled auto-merge (squash) May 19, 2026 13:06
@spalladino spalladino added the claudebox Owned by claudebox. it can push to this PR. label May 19, 2026
@spalladino

spalladino commented May 19, 2026

Copy link
Copy Markdown
Contributor

/claudebox package @aztec/viem is not published locally, we need to allow it to be proxied. Add it as an exception to the @aztec/* wildcard at the top. Also scan for other packages as well that are not published locally. Also bring in the publish: allow_offline setting from branch cb/dd69e1f0bb2f if it makes sense.

@spalladino spalladino mentioned this pull request May 19, 2026
Closed
@AztecBot

AztecBot commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

⏳ Run #1 — Session completed (10m)
Live status

Added @aztec/viem as an npm exception in docs/examples/ts/lib.sh (only @aztec/* package not local — others use link: prefix already) and brought in publish: allow_offline: true from cb/dd69e1f0bb2f. Full analysis: https://gist.github.com/AztecBot/fcbb5ff446d16891e758bcba38632ef3

@AztecBot
fix: add verdaccio allow_offline + viem proxy exception
549909d 
Two follow-up tweaks on top of the @aztec/* local block to fully avoid
the npmjs uplink E503 failure:

- publish.allow_offline: true (from cb/dd69e1f0bb2f) lets verdaccio
  accept publishes when the uplink existence check fails. This is the
  direct fix for the 503 seen on PR #23344.
- @aztec/viem is a third-party fork on npm, not built locally. Match it
  before @aztec/* so it can still be proxied from npmjs.
@alexghr alexghr disabled auto-merge May 19, 2026 15:47
@alexghr alexghr enabled auto-merge (squash) May 19, 2026 15:47
@alexghr alexghr merged commit 16ebffe into merge-train/spartan May 19, 2026
14 checks passed
@alexghr alexghr deleted the ag/fix-aztec-up-local-npm-publish branch May 19, 2026 15:48
@AztecBot AztecBot mentioned this pull request May 19, 2026
Merged
danielntmd pushed a commit to danielntmd/aztec-packages that referenced this pull request Jun 4, 2026
@PhilWindle
feat: merge-train/spartan (AztecProtocol#23344)
188d421 
BEGIN_COMMIT_OVERRIDE
refactor(p2p): merge FastTxCollection into TxCollection with sequential
pipeline (AztecProtocol#23245)
refactor(publisher): bundle-level simulate; drop per-action enqueue sims
(AztecProtocol#23165)
refactor(stdlib): remove deprecated RevertCode/TxExecutionResult aliases
(AztecProtocol#23249)
test(e2e): fix race in 'proposer invalidates multiple checkpoints'
(AztecProtocol#23259)
fix: clean up old jobs regardless of pending status (AztecProtocol#23260)
refactor(p2p): remove unused sendBatchRequest (AztecProtocol#23273)
chore(p2p): remove proposal_tx_collector leftovers (AztecProtocol#23276)
feat: slash truncated checkpoint proposals (AztecProtocol#23250)
refactor: remove unused map in attestation pool (AztecProtocol#23284)
chore(p2p): assert last block in checkpoint proposal is correct (AztecProtocol#23274)
refactor(l1-tx-utils): use DateProvider for fail-fast timeout check
(AztecProtocol#23257)
feat(sandbox): support proposer pipelining in local network (AztecProtocol#23277)
test(e2e): fix race in broadcasted_invalid_block_proposal_slash under
pipelining (AztecProtocol#23302)
fix(archiver): atomic getter for L2 tips (AztecProtocol#23295)
fix(sequencer): use targetSlot in tryVoteWhenEscapeHatchOpen under
pipelining (AztecProtocol#23296)
fix(world-state): make fork close idempotent for pruned forks (AztecProtocol#23298)
test(e2e): migrate passing tests to proposer pipelining (AztecProtocol#23275)
chore: update dashboard (AztecProtocol#23312)
chore: Revert "feat(sandbox): support proposer pipelining in local
network" (AztecProtocol#23313)
test: slash on bad attestation (AztecProtocol#23184)
feat(slasher): per-slot data-withholding watcher (A-523, A-525) (AztecProtocol#23116)
test(e2e): enable pipelining on e2e debug trace (AztecProtocol#23301)
test(e2e): enable pipelining on l1-to-l2 test (AztecProtocol#23300)
test(e2e): switch fee_settings to organic fee bumps under pipelining
(AztecProtocol#23303)
fix(ci): retry sqlite3mc-wasm download on transient DNS/TLS failures
(AztecProtocol#23333)
test(e2e): wait for real oracle rotation in fee_settings inflate helper
(AztecProtocol#23334)
test(e2e): anchor e2e_amm PXE to checkpointed tip under pipelining
(AztecProtocol#23336)
fix(spartan-bench): tolerate older node images in SlasherConfig schema
(AztecProtocol#23351)
fix: interrupt prover jobs in stop (AztecProtocol#23358)
test(e2e): enable pipelining on bot, fees, and avm simulator tests
(AztecProtocol#23329)
feat(sentinel): end-of-epoch evaluation with re-execution outcomes
(AztecProtocol#23286)
feat: slash for invalid checkpoint proposals (AztecProtocol#23270)
fix: fork closure in epoch proving jobs (AztecProtocol#23390)
fix(slasher): anchor watcher scans at archiver synced L2 slot (AztecProtocol#23394)
fix: avoid npm uplink for aztec-up local publishes (AztecProtocol#23396)
test(e2e): ignore benign 'Insufficient valid txs' block-build-failed in
epochs tests (AztecProtocol#23424)
chore: refactor weekly proving test wait (AztecProtocol#23395)
refactor: add fifo set (AztecProtocol#23271)
feat(sandbox): support proposer pipelining in local network (AztecProtocol#23327)
fix(p2p): validate BLOCK_TXS in BatchTxRequester (AztecProtocol#23371)
chore(p2p): simplify IBatchRequestTxValidator (AztecProtocol#23373)
feat(sequencer): AutomineSequencer for single-sequencer e2e tests
(AztecProtocol#23354)
fix(prover): wait for previous epoch to be proven (AztecProtocol#23458)
chore: collocate provers (AztecProtocol#23439)
chore: rm staging-ignition (AztecProtocol#23440)
chore: rm unused networks (AztecProtocol#23441)
test(e2e): migrate block_building, multi_validator_node,
publisher_funding, invalid_checkpoint_proposal to pipelining (AztecProtocol#23414)
fix(archiver): reconcile local blocks with L1 checkpoints by block
number (AztecProtocol#23461)
feat: Updated slash conditions on block proposals (AztecProtocol#23466)
test(e2e): migrate HA full test to pipelining (AztecProtocol#23463)
chore: update resource profiles (AztecProtocol#23442)
chore: update debug log levels (AztecProtocol#23456)
test: fix flaky sentinel_status_slash by asserting the fault on the
checkpoint slot (AztecProtocol#23483)
feat(slasher): slash checkpoint equivocation between P2P and L1 (A-980)
(AztecProtocol#23436)
refactor(slasher): rename ATTESTED_DESCENDANT_OF_INVALID ->
PROPOSED_DESCENDANT_OF_CHECKPOINT_WITH_INVALID_ATTESTATIONS (AztecProtocol#23468)
fix: reject block proposals in poisoned slots (AztecProtocol#23411)
fix: retry nargo dep + solc downloads to survive transient DNS drops
(AztecProtocol#23490)
fix: enrich json-rpc tracing (AztecProtocol#23412)
feat: add trace export controls (AztecProtocol#23413)
test(e2e): assert no equivocation offenses in HA full test (AztecProtocol#23496)
test: cover invalid checkpoint proposal slashing (AztecProtocol#23503)
test(e2e): migrate more e2e suites to proposer pipelining (AztecProtocol#23482)
test: flag e2e_slashing_attested_invalid_proposal as flake under
pipelining (AztecProtocol#23501)
test: flag e2e_p2p_duplicate_proposal_slash as flake under pipelining
(AztecProtocol#23515)
test(e2e): require cross-observer agreement on sentinel fault slot
(AztecProtocol#23513)
test: flag e2e_ha_full afterAll hook timeout as flake under pipelining
(AztecProtocol#23524)
fix(e2e): propagate l1ContractsArgs into node config so archiver matches
L1 (AztecProtocol#23514)
test: flag e2e_multi_validator_node_key_store P2P tx-dropped failure as
flake (AztecProtocol#23528)
test(cheat-codes): retry warpL2TimeAtLeastTo in-current-slot test on L1
race (AztecProtocol#23533)
test(e2e_ha_full): parallel HA peer node teardown with per-node deadline
(AztecProtocol#23539)
test: flag e2e_ha_full as flake under HA pipelining (AztecProtocol#23541)
test(ci): skip e2e_ha_full entirely on merge-train/spartan (AztecProtocol#23542)
test(ci): skip e2e_multi_validator_node_key_store entirely on
merge-train/spartan (AztecProtocol#23544)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilWindle PhilWindle PhilWindle approved these changes

@charlielye charlielye Awaiting requested review from charlielye charlielye is a code owner

Assignees

No one assigned

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexghr @spalladino @AztecBot @PhilWindle