Skip to content

test(ci): flake-group sentinel_status_slash warp helper#23408

Closed
AztecBot wants to merge 2 commits into
merge-train/spartanfrom
claudebox/fix-pr-23344-spartan-redux
Closed

test(ci): flake-group sentinel_status_slash warp helper#23408
AztecBot wants to merge 2 commits into
merge-train/spartanfrom
claudebox/fix-pr-23344-spartan-redux

Conversation

@AztecBot

@AztecBot AztecBot commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Unblocks merge-train/spartan after PR #23344 was dequeued (run https://github.com/AztecProtocol/aztec-packages/actions/runs/26107178186, log http://ci.aztec-labs.com/4890aba571900836). The failing test, e2e_p2p_sentinel_status_slash › slashes the proposer with INACTIVITY when checkpoint validation records invalid, errors out before reaching any slasher logic with:

Target proposer 0x90f7… not found with sufficient buffer within 20 epochs
    at warpToSlotBeforeTargetProposer (sentinel_status_slash.parallel.test.ts:295:11)

Why this flakes

In warpToSlotBeforeTargetProposer, each iteration searches the slot range
[currentSlot + 2, (currentEpoch + 2) * AZTEC_EPOCH_DURATION - 1]. With AZTEC_EPOCH_DURATION = 2 and a 2-slot buffer that eats most of the next epoch's slots, each iteration probes only 1–2 slots before calling advanceToNextEpoch(). With a 6-validator committee and the proposer schedule shuffled per epoch, the 20-attempt budget can run out before the target validator rotates into a reachable slot.

The slasher PR (#23394) that was the most recent commit on spartan does not touch this helper or the proposer schedule; this is a pre-existing setup-time probabilistic failure that the merge-queue's heavy grind (10x) surfaces more often than the PR-branch CI does.

Fix

Add the test to .test_patterns.yml with no error_regex so any failure of this test is treated as a flake — the test is brand new and shares the warp helper across all of its parallel cases, so scoping to a single error mode would leave us re-flaking on every neighbouring failure mode. The owner is Phil (added the test in #23286).

A longer-term fix is to widen the search to span multiple epochs per iteration; that belongs in a follow-up rather than on the merge train.

ClaudeBox logs:

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels May 19, 2026
@AztecBot

Copy link
Copy Markdown
Collaborator Author

Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed.

@AztecBot AztecBot closed this May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant